[MRG] Correctly handle deprecated attribute warnings and docstrings#13635
Merged
TomDLT merged 4 commits intoscikit-learn:masterfrom Apr 18, 2019
Merged
[MRG] Correctly handle deprecated attribute warnings and docstrings#13635TomDLT merged 4 commits intoscikit-learn:masterfrom
TomDLT merged 4 commits intoscikit-learn:masterfrom
Conversation
jnothman
reviewed
Apr 15, 2019
Member
jnothman
left a comment
There was a problem hiding this comment.
Just a small note that this ordering is also important for uses of other descriptor decorators, such as @if_delegate_has_method
Member
|
Nice ! |
jeremiedbb
pushed a commit
to jeremiedbb/scikit-learn
that referenced
this pull request
Apr 25, 2019
xhluca
pushed a commit
to xhluca/scikit-learn
that referenced
this pull request
Apr 28, 2019
xhluca
pushed a commit
to xhluca/scikit-learn
that referenced
this pull request
Apr 28, 2019
…ings (scikit-learn#13635)" This reverts commit 0d3b70e.
xhluca
pushed a commit
to xhluca/scikit-learn
that referenced
this pull request
Apr 28, 2019
…ings (scikit-learn#13635)" This reverts commit 0d3b70e.
koenvandevelde
pushed a commit
to koenvandevelde/scikit-learn
that referenced
this pull request
Jul 12, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #8113
Fixes #13489
Closes #8122
This PR fixes the warning and docstrings of deprecated attributes (i.e. deprecated properties):
active_featureshere (this PR) and here(dev)). Note that deprecated attributes aren't part of themethodssection anymore.For this to work we need to enforce that the
@propertydecorator comes before thedeprecateddecorator.I updated the contributing guide and added a CI check regarding this.