[MRG] MNT Use a common language_level cython directive#13630
Merged
rth merged 1 commit intoscikit-learn:masterfrom Apr 13, 2019
Merged
[MRG] MNT Use a common language_level cython directive#13630rth merged 1 commit intoscikit-learn:masterfrom
rth merged 1 commit intoscikit-learn:masterfrom
Conversation
NicolasHug
approved these changes
Apr 12, 2019
Member
NicolasHug
left a comment
There was a problem hiding this comment.
Good idea, LGTM.
Do you think we could(/should?) do the same for other directives like boundchecks, wraparound, cdivision? Seems like we set them most of the time.
Member
Author
|
I tried but it was not straightforward :) |
rth
approved these changes
Apr 13, 2019
| # skip comments | ||
| line_cstr = line | ||
| hash_ptr = strchr(line_cstr, '#') | ||
| hash_ptr = strchr(line_cstr, 35) # ASCII value of '#' is 35 |
Member
There was a problem hiding this comment.
Nice! This was the part missing in #12873 that prevented me to use a global option.
jeremiedbb
added a commit
to jeremiedbb/scikit-learn
that referenced
this pull request
Apr 25, 2019
xhluca
pushed a commit
to xhluca/scikit-learn
that referenced
this pull request
Apr 28, 2019
koenvandevelde
pushed a commit
to koenvandevelde/scikit-learn
that referenced
this pull request
Jul 12, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cython compile directives can be commonly set during cythonization.
This PR does it for the
language_leveldirective.There was a file (``_svmlight_format.pyx) where it was still level 2 but it was easily fixable.