[MRG+1] Extension of v_measure_score metric to include beta parameter#13607
Merged
thomasjpfan merged 24 commits intoscikit-learn:masterfrom Apr 16, 2019
Merged
[MRG+1] Extension of v_measure_score metric to include beta parameter#13607thomasjpfan merged 24 commits intoscikit-learn:masterfrom
thomasjpfan merged 24 commits intoscikit-learn:masterfrom
Conversation
jnothman
reviewed
Apr 10, 2019
…ed formula in case beta != 1.0 is passed [ci skip]
Contributor
Author
|
Do you think this test coverage is sufficient ? Should I add a test for when It seems the scikit-learn.scikit-learn build is failing due to an error in Debian Jessie in #13590 |
scouvreur
commented
Apr 11, 2019
jnothman
reviewed
Apr 12, 2019
…mogeneity_completeness_v_measure function docstrings
…ity_completeness_v_measure function
…et al. and compare to value returned by the function
…sure and v_measure_score function docstrings
thomasjpfan
reviewed
Apr 12, 2019
Co-Authored-By: scouvreur <stephane.couvreur@feedzai.com>
jnothman
approved these changes
Apr 15, 2019
Co-Authored-By: scouvreur <stephane.couvreur@feedzai.com>
jnothman
reviewed
Apr 15, 2019
Contributor
Author
|
Thanks for your help and feedback @jnothman @thomasjpfan ! |
Member
|
Thank you! @scouvreur |
jeremiedbb
pushed a commit
to jeremiedbb/scikit-learn
that referenced
this pull request
Apr 25, 2019
xhluca
pushed a commit
to xhluca/scikit-learn
that referenced
this pull request
Apr 28, 2019
xhluca
pushed a commit
to xhluca/scikit-learn
that referenced
this pull request
Apr 28, 2019
…eter (scikit-learn#13607)" This reverts commit ee4a255.
xhluca
pushed a commit
to xhluca/scikit-learn
that referenced
this pull request
Apr 28, 2019
…eter (scikit-learn#13607)" This reverts commit ee4a255.
koenvandevelde
pushed a commit
to koenvandevelde/scikit-learn
that referenced
this pull request
Jul 12, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
This PR is an enhancement proposed in #13595 to the
v_measure_scoremetric.As mentioned there by @ivsanro1 :
What does this implement/fix? Explain your changes.
This PR adds an additional parameter
betato thev_measure_scoremetric insklearn/metrics/cluster/supervised.pyto allow for different weight to be attributed to homogeneity or completeness as proposed in "V-Measure: A conditional entropy-based external cluster evaluation measure" (A. Rosenthal et al.).If
beta = 1.0(default), the function returns unchanged thehomogeneity_completeness_v_measure. Else, it returns:as explained p. 412 of the paper.
Tasks
betaparameter to:homogeneity_completeness_v_measurev_measure_scorebetais passed to:homogeneity_completeness_v_measurev_measure_score