Skip to content

Add reference to suggested article#13561

Merged
jnothman merged 3 commits intoscikit-learn:masterfrom
mani2106:mani2106-tree-reference-addition
Apr 4, 2019
Merged

Add reference to suggested article#13561
jnothman merged 3 commits intoscikit-learn:masterfrom
mani2106:mani2106-tree-reference-addition

Conversation

@mani2106
Copy link
Copy Markdown
Contributor

@mani2106 mani2106 commented Apr 2, 2019

Added a suggested article to help the reader understand the structure of the decision tree

Reference Issues/PRs

Fixes #13558

What does this implement/fix? Explain your changes.

Added reference to suggested useful article

Any other comments?

None

Added a suggested article to help the reader understand the structure of the decision tree
Copy link
Copy Markdown
Contributor

@albertcthomas albertcthomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @mani2106

Added the suggested article to Examples and Tips on Practical use section, and removed it from references
Copy link
Copy Markdown
Member

@NicolasHug NicolasHug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!


* https://en.wikipedia.org/wiki/Predictive_analytics

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please avoid blank spaces

@NicolasHug NicolasHug self-requested a review April 4, 2019 10:35
give your tree a better chance of finding features that are discriminative.

* :ref:`sphx_glr_auto_examples_tree_plot_unveil_tree_structure.py` will help
in gaining more insights about the nodes which can have an influence over the
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"how a tree makes predictions" might be clearer than "the nodes which can have an influence ..."

Modified description for the preferred link
Copy link
Copy Markdown
Member

@jnothman jnothman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mani2106

@jnothman jnothman merged commit 921c8f3 into scikit-learn:master Apr 4, 2019
@mani2106 mani2106 deleted the mani2106-tree-reference-addition branch April 5, 2019 03:12
jeremiedbb pushed a commit to jeremiedbb/scikit-learn that referenced this pull request Apr 25, 2019
xhluca pushed a commit to xhluca/scikit-learn that referenced this pull request Apr 28, 2019
xhluca pushed a commit to xhluca/scikit-learn that referenced this pull request Apr 28, 2019
xhluca pushed a commit to xhluca/scikit-learn that referenced this pull request Apr 28, 2019
koenvandevelde pushed a commit to koenvandevelde/scikit-learn that referenced this pull request Jul 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Reference Understanding the decision tree structure example in the User Guide

4 participants