[MRG] DOC Fix missing space after backquotes#13551
Merged
qinhanmin2014 merged 2 commits intoscikit-learn:masterfrom Apr 1, 2019
Merged
[MRG] DOC Fix missing space after backquotes#13551qinhanmin2014 merged 2 commits intoscikit-learn:masterfrom
qinhanmin2014 merged 2 commits intoscikit-learn:masterfrom
Conversation
Contributor
Author
|
There is only one other similar mistake in grep -rI --include='*.html' '`\`\`' doc/_build/html/stable/returns: doc/_build/html/stable/whats_new/v0.17.html:<code class="docutils literal notranslate"><span class="pre">class_weight='balanced'```or</span> <span class="pre">``class_weight='auto'</span></code>.Should I fix it too? |
NicolasHug
approved these changes
Mar 31, 2019
Member
NicolasHug
left a comment
There was a problem hiding this comment.
LGTM
Should I fix it too?
Sure, thanks!
Contributor
Author
|
Thanks @NicolasHug! Fixed in 444a928 |
qinhanmin2014
approved these changes
Apr 1, 2019
Member
qinhanmin2014
left a comment
There was a problem hiding this comment.
LGTM, thanks @Framartin
jeremiedbb
pushed a commit
to jeremiedbb/scikit-learn
that referenced
this pull request
Apr 25, 2019
xhluca
pushed a commit
to xhluca/scikit-learn
that referenced
this pull request
Apr 28, 2019
xhluca
pushed a commit
to xhluca/scikit-learn
that referenced
this pull request
Apr 28, 2019
This reverts commit a267f3e.
xhluca
pushed a commit
to xhluca/scikit-learn
that referenced
this pull request
Apr 28, 2019
This reverts commit a267f3e.
koenvandevelde
pushed a commit
to koenvandevelde/scikit-learn
that referenced
this pull request
Jul 12, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
None
What does this implement/fix? Explain your changes.
One missing space after the double backquotes makes the inline markup for code samples to expend to the next one. Then, the sentence is incorrectly formatted as:
Instead of:
