[MRG] Added doc on how to override estimator tags#13550
Merged
qinhanmin2014 merged 4 commits intoscikit-learn:masterfrom Apr 2, 2019
Merged
[MRG] Added doc on how to override estimator tags#13550qinhanmin2014 merged 4 commits intoscikit-learn:masterfrom
qinhanmin2014 merged 4 commits intoscikit-learn:masterfrom
Conversation
jnothman
reviewed
Apr 1, 2019
Member
jnothman
left a comment
There was a problem hiding this comment.
Thanks. Another thing we should do is reference relevant tags in error messages raised by estimator checks.
doc/whats_new/v0.21.rst
Outdated
| `predict`, `predict_proba`, `transform`, and `decision_function` does not | ||
| change. :issue:`12328` by :user:`Nicolas Hug <NicolasHug>` | ||
|
|
||
| - Add estimators tags: these are annotations of estimators that allow |
Member
There was a problem hiding this comment.
Maybe this belongs in "Multiple modules" and the comment here should be that some checks will now be run selectively depending on the estimator's tags
doc/whats_new/v0.21.rst
Outdated
|
|
||
| - Add estimators tags: these are annotations of estimators that allow | ||
| programmatic inspection of their capabilities, such as sparse matrix | ||
| support, supported output types and supported methods. |
Member
Author
|
Thanks for the review Joel. Should this be labeled as |
rth
approved these changes
Apr 1, 2019
doc/whats_new/v0.21.rst
Outdated
| - Add estimators tags: these are annotations of estimators that allow | ||
| programmatic inspection of their capabilities, such as sparse matrix | ||
| support, supported output types and supported methods. The estimators checks | ||
| are now run selectively, depending on the estimator's tags. Read more in the |
Member
There was a problem hiding this comment.
This may sounds a bit confusing, as estimator checks were always run selectively. Maybe,
Estimator tags also determine tests that are run on an estimator when `check_estimator` is called.
qinhanmin2014
approved these changes
Apr 1, 2019
doc/whats_new/v0.21.rst
Outdated
| - |Efficiency| Memory copies are avoided when casting arrays to a different | ||
| dtype in multiple estimators. :issue:`11973` by :user:`Roman Yurchak | ||
| <rth>`. | ||
| - Add estimators tags: these are annotations of estimators that allow |
Member
There was a problem hiding this comment.
Could just be feature in terms of user impact. It's a major achievement on our part
jnothman
approved these changes
Apr 2, 2019
qinhanmin2014
approved these changes
Apr 2, 2019
jeremiedbb
pushed a commit
to jeremiedbb/scikit-learn
that referenced
this pull request
Apr 25, 2019
xhluca
pushed a commit
to xhluca/scikit-learn
that referenced
this pull request
Apr 28, 2019
koenvandevelde
pushed a commit
to koenvandevelde/scikit-learn
that referenced
this pull request
Jul 12, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Closes #13374
What does this implement/fix? Explain your changes.
_more_tagswasn't mentioned anywhere)