[MRG] Added additional tips for pytest usage#13540
Merged
adrinjalali merged 3 commits intoscikit-learn:masterfrom Mar 28, 2019
Merged
[MRG] Added additional tips for pytest usage#13540adrinjalali merged 3 commits intoscikit-learn:masterfrom
adrinjalali merged 3 commits intoscikit-learn:masterfrom
Conversation
rth
approved these changes
Mar 28, 2019
Member
rth
left a comment
There was a problem hiding this comment.
Thanks @NicolasHug !
I also use these frequently and it's true that they are not much documented in the contribution guide.
rth
reviewed
Mar 28, 2019
Member
|
good one! |
Member
|
I don't know if we mention it but pytest-sugar is also a must have. |
xhluca
pushed a commit
to xhluca/scikit-learn
that referenced
this pull request
Apr 28, 2019
* Added additional tips for pytest * Added --ff option * typo
xhluca
pushed a commit
to xhluca/scikit-learn
that referenced
this pull request
Apr 28, 2019
This reverts commit 0a5e164.
xhluca
pushed a commit
to xhluca/scikit-learn
that referenced
this pull request
Apr 28, 2019
This reverts commit 0a5e164.
koenvandevelde
pushed a commit
to koenvandevelde/scikit-learn
that referenced
this pull request
Jul 12, 2019
* Added additional tips for pytest * Added --ff option * typo
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR:
contributing.rstto the pytest tips and tricks.-x,--lf,-s,tb=short-Werror::DeprecationWarningand-Werror::FutureWarningflags. This isn't mentioned anywhere as far as I know and it is often a source of confusion for new contributors. See e.g. Add an easy way to run pytest -Werror::DeprecationWarning -Werror::FutureWarning #13396