Merged
Conversation
Per GCC documentation [1] permitted optimization forms are -O0, -O1 -O2, -O3, and -Os [1] https://gcc.gnu.org/onlinedocs/gnat_ugn/Optimization-Levels.html Using -O4 is interpreted as -O3 with a warning, at least with some GCC compatible compilers, e.g. Intel(R) C Compiler
adrinjalali
approved these changes
Mar 27, 2019
Member
adrinjalali
left a comment
There was a problem hiding this comment.
LGTM, thanks @oleksandr-pavlyk
rth
approved these changes
Mar 27, 2019
Member
rth
left a comment
There was a problem hiding this comment.
Thanks @oleksandr-pavlyk ! The Circle CI failure is unrelated, merging.
xhluca
pushed a commit
to xhluca/scikit-learn
that referenced
this pull request
Apr 28, 2019
koenvandevelde
pushed a commit
to koenvandevelde/scikit-learn
that referenced
this pull request
Jul 12, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace
extra_compile_args=['-O4']withextra_compile_args=['-O3']insklearn/manifold/setup.py
Per GCC documentation [1] permitted optimization
forms are -O0, -O1 -O2, -O3, and -Os
[1] https://gcc.gnu.org/onlinedocs/gnat_ugn/Optimization-Levels.html
Using -O4 is interpreted as -O3 with a warning,
at least with some GCC compatible compilers, e.g.
Intel(R) C Compiler