TST Only use activate for conda builds on windows#13517
Merged
adrinjalali merged 1 commit intoscikit-learn:masterfrom Mar 26, 2019
Merged
TST Only use activate for conda builds on windows#13517adrinjalali merged 1 commit intoscikit-learn:masterfrom
adrinjalali merged 1 commit intoscikit-learn:masterfrom
Conversation
Member
|
I think the other thing that was surprising in the issue was that the build did not fail as a result of this failing command. Can we change that? |
Member
Author
|
Batch scripting is an interesting beast. To get it to "early exit" from a command, we would need to append each command with In our case, it would be |
Member
|
Thanks @thomasjpfan |
xhluca
pushed a commit
to xhluca/scikit-learn
that referenced
this pull request
Apr 28, 2019
xhluca
pushed a commit
to xhluca/scikit-learn
that referenced
this pull request
Apr 28, 2019
…learn#13517)" This reverts commit cb3385b.
xhluca
pushed a commit
to xhluca/scikit-learn
that referenced
this pull request
Apr 28, 2019
…learn#13517)" This reverts commit cb3385b.
koenvandevelde
pushed a commit
to koenvandevelde/scikit-learn
that referenced
this pull request
Jul 12, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Fixes #13512
What does this implement/fix? Explain your changes.
Only 64 bit Windows uses conda which has access to the
activatecommand.