Skip to content

[MRG] Fix typos in doc/developers/contributing.rst#13475

Merged
qinhanmin2014 merged 1 commit intoscikit-learn:masterfrom
michaelshiyu:fix_typos
Mar 19, 2019
Merged

[MRG] Fix typos in doc/developers/contributing.rst#13475
qinhanmin2014 merged 1 commit intoscikit-learn:masterfrom
michaelshiyu:fix_typos

Conversation

@michaelshiyu
Copy link
Copy Markdown
Contributor

@michaelshiyu michaelshiyu commented Mar 19, 2019

Reference Issues/PRs

None.

What does this implement/fix? Explain your changes.

Fixed grammar mistakes and a typo in doc/developers/contributing.rst including:

  • line 1463: "Tags can depends on..."

  • line 1512: "The goals is that ... used during testsing..."

  • line 1518: "... estimators are also need to ..."

Any other comments?

None.

Copy link
Copy Markdown
Member

@qinhanmin2014 qinhanmin2014 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @michaelshiyu

@qinhanmin2014 qinhanmin2014 merged commit 777a5e4 into scikit-learn:master Mar 19, 2019
xhluca pushed a commit to xhluca/scikit-learn that referenced this pull request Apr 28, 2019
xhluca pushed a commit to xhluca/scikit-learn that referenced this pull request Apr 28, 2019
xhluca pushed a commit to xhluca/scikit-learn that referenced this pull request Apr 28, 2019
koenvandevelde pushed a commit to koenvandevelde/scikit-learn that referenced this pull request Jul 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants