MNT Redundant code in optics#13462
Merged
qinhanmin2014 merged 1 commit intoscikit-learn:masterfrom Mar 18, 2019
qinhanmin2014:OPTICS
Merged
MNT Redundant code in optics#13462qinhanmin2014 merged 1 commit intoscikit-learn:masterfrom qinhanmin2014:OPTICS
qinhanmin2014 merged 1 commit intoscikit-learn:masterfrom
qinhanmin2014:OPTICS
Conversation
adrinjalali
approved these changes
Mar 18, 2019
Member
adrinjalali
left a comment
There was a problem hiding this comment.
Definitely looks better :)
jnothman
approved these changes
Mar 18, 2019
xhluca
pushed a commit
to xhluca/scikit-learn
that referenced
this pull request
Apr 28, 2019
xhluca
pushed a commit
to xhluca/scikit-learn
that referenced
this pull request
Apr 28, 2019
This reverts commit 534e271.
xhluca
pushed a commit
to xhluca/scikit-learn
that referenced
this pull request
Apr 28, 2019
This reverts commit 534e271.
koenvandevelde
pushed a commit
to koenvandevelde/scikit-learn
that referenced
this pull request
Jul 12, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
slightly faster and clearer, perhaps?