Skip to content

[MRG+1] MAINT: Make scoring metric info uniform across scikit-learn#13449

Merged
jnothman merged 1 commit intoscikit-learn:masterfrom
bharatr21:update-score
Mar 17, 2019
Merged

[MRG+1] MAINT: Make scoring metric info uniform across scikit-learn#13449
jnothman merged 1 commit intoscikit-learn:masterfrom
bharatr21:update-score

Conversation

@bharatr21
Copy link
Copy Markdown
Contributor

Reference Issues/PRs

Continued from #13445

What does this implement/fix? Explain your changes.

As suggested by @jnothman in #13445 , this changes all instances of estimator's default scorer to estimator's "score method"

@bharatr21 bharatr21 changed the title [MRG] Make scoring metric info uniform across scikit-learn [MRG] MAINT: Make scoring metric info uniform across scikit-learn Mar 15, 2019
Copy link
Copy Markdown
Member

@adrinjalali adrinjalali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @Bharat123rox !

@adrinjalali adrinjalali changed the title [MRG] MAINT: Make scoring metric info uniform across scikit-learn [MRG+1] MAINT: Make scoring metric info uniform across scikit-learn Mar 17, 2019
@jnothman jnothman merged commit eaca172 into scikit-learn:master Mar 17, 2019
xhluca pushed a commit to xhluca/scikit-learn that referenced this pull request Apr 28, 2019
xhluca pushed a commit to xhluca/scikit-learn that referenced this pull request Apr 28, 2019
xhluca pushed a commit to xhluca/scikit-learn that referenced this pull request Apr 28, 2019
koenvandevelde pushed a commit to koenvandevelde/scikit-learn that referenced this pull request Jul 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants