Skip to content

Alternative sub-module displayed in warning msg.#13426

Merged
qinhanmin2014 merged 2 commits intoscikit-learn:masterfrom
moibra:moh_dev
Mar 10, 2019
Merged

Alternative sub-module displayed in warning msg.#13426
qinhanmin2014 merged 2 commits intoscikit-learn:masterfrom
moibra:moh_dev

Conversation

@moibra
Copy link
Copy Markdown
Contributor

@moibra moibra commented Mar 9, 2019

Reference Issues/PRs

Fixes #13387.

What does this implement/fix? Explain your changes.

Displays the alternative within the warning when importing the deprecating package sklearn.datasets.fetch_mldata.

Any other comments?

I'm a novice.

Copy link
Copy Markdown
Member

@rth rth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @moibra !


@deprecated('mldata_filename was deprecated in version 0.20 and will be '
'removed in version 0.22')
'removed in version 0.22 . Please use fetch_openml. ')
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please get rid of the redundant spaces, i.e., before the first . and after the second .

Copy link
Copy Markdown
Member

@qinhanmin2014 qinhanmin2014 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @moibra

@qinhanmin2014 qinhanmin2014 merged commit d78ddb4 into scikit-learn:master Mar 10, 2019
@moibra moibra deleted the moh_dev branch March 10, 2019 04:16
xhluca pushed a commit to xhluca/scikit-learn that referenced this pull request Apr 28, 2019
xhluca pushed a commit to xhluca/scikit-learn that referenced this pull request Apr 28, 2019
xhluca pushed a commit to xhluca/scikit-learn that referenced this pull request Apr 28, 2019
koenvandevelde pushed a commit to koenvandevelde/scikit-learn that referenced this pull request Jul 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fetch_mldata deprecation warning with no suggested alternative

3 participants