Add attributes to MultiOutputRegressor docstring#13420
Merged
qinhanmin2014 merged 2 commits intoscikit-learn:masterfrom Mar 11, 2019
albertotb:doc_multioutput
Merged
Add attributes to MultiOutputRegressor docstring#13420qinhanmin2014 merged 2 commits intoscikit-learn:masterfrom albertotb:doc_multioutput
qinhanmin2014 merged 2 commits intoscikit-learn:masterfrom
albertotb:doc_multioutput
Conversation
MultiOutputRegressor is missing the estimators_ attribute in the documentation
jnothman
approved these changes
Mar 10, 2019
jnothman
reviewed
Mar 10, 2019
sklearn/multioutput.py
Outdated
| When individual estimators are fast to train or predict | ||
| using `n_jobs>1` can result in slower performance due | ||
| to the overhead of spawning processes. | ||
|
|
Member
There was a problem hiding this comment.
Pep8 is complaining that you have added a blank line that contains white space. Blank lines must be empty.
Contributor
Author
There was a problem hiding this comment.
It should be fixed now
qinhanmin2014
approved these changes
Mar 11, 2019
Member
qinhanmin2014
left a comment
There was a problem hiding this comment.
LGTM, thanks @albertotb
xhluca
pushed a commit
to xhluca/scikit-learn
that referenced
this pull request
Apr 28, 2019
xhluca
pushed a commit
to xhluca/scikit-learn
that referenced
this pull request
Apr 28, 2019
…learn#13420)" This reverts commit a61d517.
xhluca
pushed a commit
to xhluca/scikit-learn
that referenced
this pull request
Apr 28, 2019
…learn#13420)" This reverts commit a61d517.
koenvandevelde
pushed a commit
to koenvandevelde/scikit-learn
that referenced
this pull request
Jul 12, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this implement/fix? Explain your changes.
MultiOutputRegressor()is missing theestimators_attribute in the documentationAny other comments?
MultiOutputClassifier()is fine, so I just copied the Attributes part from the docstring