Skip to content

DOC Fix typo in FunctionTransformer#13404

Merged
TomDLT merged 1 commit intoscikit-learn:masterfrom
CaselIT:patch-1
Mar 7, 2019
Merged

DOC Fix typo in FunctionTransformer#13404
TomDLT merged 1 commit intoscikit-learn:masterfrom
CaselIT:patch-1

Conversation

@CaselIT
Copy link
Copy Markdown
Contributor

@CaselIT CaselIT commented Mar 6, 2019

What does this implement/fix? Explain your changes.

Fix typo in FunctionTransformer deprecation of pass_y argument.

In the documentation there is no mention of that pass_y is deprecated:
https://scikit-learn.org/stable/modules/generated/sklearn.preprocessing.FunctionTransformer.html#sklearn.preprocessing.FunctionTransformer

Copy link
Copy Markdown
Member

@TomDLT TomDLT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

circle-ci looks good.
git grep shows no other identical errors, nor with versionadded.
LGTM

@TomDLT TomDLT merged commit 457b0d0 into scikit-learn:master Mar 7, 2019
@TomDLT
Copy link
Copy Markdown
Member

TomDLT commented Mar 7, 2019

Thanks @CaselIT !

@CaselIT CaselIT deleted the patch-1 branch March 7, 2019 06:44
xhluca pushed a commit to xhluca/scikit-learn that referenced this pull request Apr 28, 2019
xhluca pushed a commit to xhluca/scikit-learn that referenced this pull request Apr 28, 2019
xhluca pushed a commit to xhluca/scikit-learn that referenced this pull request Apr 28, 2019
koenvandevelde pushed a commit to koenvandevelde/scikit-learn that referenced this pull request Jul 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants