DOC Fix a typo in cross_validation.rst#13398
Merged
qinhanmin2014 merged 3 commits intoscikit-learn:masterfrom Mar 7, 2019
Kulbear:fix-typo-cross-validation
Merged
DOC Fix a typo in cross_validation.rst#13398qinhanmin2014 merged 3 commits intoscikit-learn:masterfrom Kulbear:fix-typo-cross-validation
qinhanmin2014 merged 3 commits intoscikit-learn:masterfrom
Kulbear:fix-typo-cross-validation
Conversation
Member
|
there's a typo indeed, but I think the key should be changed, not the value. |
Contributor
Author
|
@amueller Yeah, comparing two macro metrics seem to be more reasonable. Updated. |
Member
|
you need to also change the expected output, see CI failure. |
Member
|
Also: thanks for your contribution and the quick update. Sorry I can be a bit terse ;) |
Contributor
Author
|
@amueller Glad to make it work! |
TomDLT
approved these changes
Mar 6, 2019
xhluca
pushed a commit
to xhluca/scikit-learn
that referenced
this pull request
Apr 28, 2019
xhluca
pushed a commit
to xhluca/scikit-learn
that referenced
this pull request
Apr 28, 2019
This reverts commit 2aeef05.
xhluca
pushed a commit
to xhluca/scikit-learn
that referenced
this pull request
Apr 28, 2019
This reverts commit 2aeef05.
koenvandevelde
pushed a commit
to koenvandevelde/scikit-learn
that referenced
this pull request
Jul 12, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
None
What does this implement/fix? Explain your changes.
I believe there is a typo in the documentation for cross validation, as I have changed.
Any other comments?
Options could be either change the key name in the dict
scoringor the keyword argument inmake_scorer.I went for the second option.