DOC update and extend maintainer docs for making releases#13377
DOC update and extend maintainer docs for making releases#13377qinhanmin2014 merged 4 commits intoscikit-learn:masterfrom
Conversation
doc/developers/maintainer.rst
Outdated
| $ git tag -a 0.999 | ||
|
|
||
| $ git push origin --tags | ||
| $ git push https://github.com/scikit-learn/scikit-learn --tags |
There was a problem hiding this comment.
probably upstream would make more sense. Or the git-ssh link instead of https, since https and 2FA are not besties. On the other hand, at the point somebody's doing this release, they can figure this out themselves. So no hard feelings.
There was a problem hiding this comment.
https and 2FA are fine as long as you keep your token. Shrug. Can change
doc/developers/maintainer.rst
Outdated
| in https://github.com/scikit-learn/scikit-learn.github.io:: | ||
|
|
||
| $ cd /tmp | ||
| $ git clone --depth 1 --no-checkout https://github.com/scikit-learn/scikit-learn.github.io |
There was a problem hiding this comment.
shouldn't we default on git-ssh really?
There was a problem hiding this comment.
Why? By far the majority of the time is spent in file transfer in which I would think the overhead is negligible in both cases...?
There was a problem hiding this comment.
Or do you mean to make push easy, assuming keys are set up? I don't find pushing with 2FA to https a big problem, personally...
adrinjalali
left a comment
There was a problem hiding this comment.
Otherwise LGTM, thanks @jnothman :)
…ikit-learn#13377)" This reverts commit f41fc5b.
…ikit-learn#13377)" This reverts commit f41fc5b.
Need to check rendering as well as have content reviewed.