[MRG+1] DOC: fix formatting in whats_new#13375
Merged
qinhanmin2014 merged 2 commits intoscikit-learn:masterfrom Mar 3, 2019
Merged
[MRG+1] DOC: fix formatting in whats_new#13375qinhanmin2014 merged 2 commits intoscikit-learn:masterfrom
qinhanmin2014 merged 2 commits intoscikit-learn:masterfrom
Conversation
Member
Author
|
Rendered version (to check visually): |
jnothman
reviewed
Mar 2, 2019
jnothman
approved these changes
Mar 2, 2019
chkoar
reviewed
Mar 2, 2019
doc/whats_new/v0.21.rst
Outdated
| ``float32`` and ``float64`` dtypes. :issues:`8769` and :issues:`11000` by | ||
| :user:`Nelle Varoquaux`_, :user:`Arthur Imbert <Henley13>`, | ||
| ``float32`` and ``float64`` dtypes. :issue:`8769` and :issue:`11000` by | ||
| :user:`Nelle Varoquaux`, :user:`Arthur Imbert <Henley13>`, |
Contributor
There was a problem hiding this comment.
The link is broken for Nelle
Member
Author
There was a problem hiding this comment.
Indeed. Thanks. Fixed!
86f93de to
8c8343b
Compare
Member
Author
|
Addressed comments (that were very relevant, thanks!) |
Member
Author
|
New rendered version, with the fixes: https://50448-843222-gh.circle-artifacts.com/0/doc/whats_new.html |
qinhanmin2014
approved these changes
Mar 3, 2019
xhluca
pushed a commit
to xhluca/scikit-learn
that referenced
this pull request
Apr 28, 2019
xhluca
pushed a commit
to xhluca/scikit-learn
that referenced
this pull request
Apr 28, 2019
This reverts commit d1f230c.
xhluca
pushed a commit
to xhluca/scikit-learn
that referenced
this pull request
Apr 28, 2019
This reverts commit d1f230c.
koenvandevelde
pushed a commit
to koenvandevelde/scikit-learn
that referenced
this pull request
Jul 12, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A simple fix because I was distracted by formatting errors in the whats_new for 0.21.