Add examples to Adaboost estimators #13373
Merged
qinhanmin2014 merged 13 commits intoscikit-learn:masterfrom Mar 4, 2019
Merged
Add examples to Adaboost estimators #13373qinhanmin2014 merged 13 commits intoscikit-learn:masterfrom
qinhanmin2014 merged 13 commits intoscikit-learn:masterfrom
Conversation
Member
|
tests failing |
added 2 commits
March 2, 2019 19:32
Contributor
Author
|
@adrinjalali fixed |
adrinjalali
reviewed
Mar 2, 2019
sklearn/ensemble/weight_boosting.py
Outdated
| >>> regr.fit(X, y) # doctest: +NORMALIZE_WHITESPACE | ||
| AdaBoostRegressor(base_estimator=None, learning_rate=1.0, loss='linear', | ||
| n_estimators=100, random_state=0) | ||
| >>> print(regr.feature_importances_) |
Member
There was a problem hiding this comment.
please use # doctest: +ELLIPSIS here and keep all the following floating points to max 4 digits. This level of precision causes us headaches when we try to build for all the platforms we do. (i.e. 0.27885832 -> 0.2788...)
Contributor
Author
There was a problem hiding this comment.
That might exists in a bunch of places
adrinjalali
reviewed
Mar 2, 2019
Contributor
Author
|
For some reason azure pipelines didn't run |
Member
|
@thomasjpfan do you know why Azure CI hasn't run this PR? |
adrinjalali
approved these changes
Mar 3, 2019
Member
adrinjalali
left a comment
There was a problem hiding this comment.
Azure CI hasn't run for the last commit, aside from nitpick, LGTM, thanks @chkoar
adrinjalali
reviewed
Mar 3, 2019
added 2 commits
March 4, 2019 15:28
Member
|
flake8 error, otherwise LGTM |
added 2 commits
March 4, 2019 16:23
qinhanmin2014
approved these changes
Mar 4, 2019
xhluca
pushed a commit
to xhluca/scikit-learn
that referenced
this pull request
Apr 28, 2019
xhluca
pushed a commit
to xhluca/scikit-learn
that referenced
this pull request
Apr 28, 2019
This reverts commit 0326353.
xhluca
pushed a commit
to xhluca/scikit-learn
that referenced
this pull request
Apr 28, 2019
This reverts commit 0326353.
koenvandevelde
pushed a commit
to koenvandevelde/scikit-learn
that referenced
this pull request
Jul 12, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
#3846
What does this implement/fix? Explain your changes.
Solves part of the issue #3846 about missing examples from the class docs.