Skip to content

Fix bad double to integer cast in __fit_and_predict for cross_val_predict#13368

Merged
agramfort merged 3 commits intoscikit-learn:masterfrom
gfournier:fix_validation_missing_class
Mar 3, 2019
Merged

Fix bad double to integer cast in __fit_and_predict for cross_val_predict#13368
agramfort merged 3 commits intoscikit-learn:masterfrom
gfournier:fix_validation_missing_class

Conversation

@gfournier
Copy link
Copy Markdown
Contributor

Reference Issues/PRs

Fixes #13366

What does this implement/fix? Explain your changes.

It fixes the typing of a result numpy array.

@agramfort
Copy link
Copy Markdown
Member

@gfournier you should also update v0.21.rst file

@gfournier gfournier force-pushed the fix_validation_missing_class branch from 877d3b7 to 9d579b8 Compare March 2, 2019 10:41
@gfournier
Copy link
Copy Markdown
Contributor Author

@gfournier you should also update v0.21.rst file

done in 9d579b8

@agramfort agramfort merged commit 50946b3 into scikit-learn:master Mar 3, 2019
xhluca pushed a commit to xhluca/scikit-learn that referenced this pull request Apr 28, 2019
…dict (scikit-learn#13368)

* Fix bad double to integer cast in __fit_and_predict for cross_val_predict

* Fix flake8 errors

* Add documentation to changelog
xhluca pushed a commit to xhluca/scikit-learn that referenced this pull request Apr 28, 2019
xhluca pushed a commit to xhluca/scikit-learn that referenced this pull request Apr 28, 2019
koenvandevelde pushed a commit to koenvandevelde/scikit-learn that referenced this pull request Jul 12, 2019
…dict (scikit-learn#13368)

* Fix bad double to integer cast in __fit_and_predict for cross_val_predict

* Fix flake8 errors

* Add documentation to changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

cross_val_predict returns bad prediction when evaluated on a dataset with very few samples

3 participants