[MRG+1] Fix bug in AffinityPropagation#13334
Merged
agramfort merged 2 commits intoscikit-learn:masterfrom Mar 1, 2019
Merged
Conversation
7 tasks
agramfort
approved these changes
Feb 28, 2019
jnothman
approved these changes
Mar 1, 2019
Member
jnothman
left a comment
There was a problem hiding this comment.
Have you changed it back to WIP because Windows failed? It looks like something in the system, not your code. This looks fine.
| def test_affinity_propagation_convergence_warning_dense_sparse(centers): | ||
| """Assert that no convergence warning is printed for the sparse case and | ||
| the dense case if we have clusters, even if these clusters are zeros (non | ||
| regression test because of a bug that raised the warning for sparse |
Contributor
Author
There was a problem hiding this comment.
Allright, thanks
Done
Contributor
Author
Yes exactly, good, I'll set it in MRG as soon as I address your comment |
Contributor
Author
|
I addressed your comments @jnothman, tell me how that sounds |
wdevazelhes
pushed a commit
to wdevazelhes/scikit-learn
that referenced
this pull request
Mar 1, 2019
Contributor
Author
|
all checks are green @agramfort @jnothman |
Member
|
thx @wdevazelhes |
xhluca
pushed a commit
to xhluca/scikit-learn
that referenced
this pull request
Apr 28, 2019
* Fix bug in AffinityPropagation * address joel's review
xhluca
pushed a commit
to xhluca/scikit-learn
that referenced
this pull request
Apr 28, 2019
This reverts commit 35f3063.
xhluca
pushed a commit
to xhluca/scikit-learn
that referenced
this pull request
Apr 28, 2019
This reverts commit 35f3063.
koenvandevelde
pushed a commit
to koenvandevelde/scikit-learn
that referenced
this pull request
Jul 12, 2019
* Fix bug in AffinityPropagation * address joel's review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces a fix and a non regression test on a bug of AffinityPropagation (see #13246, and comment https://github.com/scikit-learn/scikit-learn/pull/13246/files#r260758475)
.sizeon a sparse array of zeros returned 0 doing as if the array was empty which it was not