MRG don't warn on changing dtypes in scalers#13306
Merged
amueller merged 3 commits intoscikit-learn:masterfrom Feb 28, 2019
Merged
MRG don't warn on changing dtypes in scalers#13306amueller merged 3 commits intoscikit-learn:masterfrom
amueller merged 3 commits intoscikit-learn:masterfrom
Conversation
Member
jorisvandenbossche
left a comment
There was a problem hiding this comment.
If we go through with this, we might actually remove that keyword from check_array, because those were the only use cases now internally.
| """ # noqa | ||
| X = check_array(X, accept_sparse='csc', copy=copy, ensure_2d=False, | ||
| warn_on_dtype=True, estimator='the scale function', | ||
| warn_on_dtype=False, estimator='the scale function', |
Member
There was a problem hiding this comment.
can also just remove the warn_on_dtype=False here, as that is the default of check_array
glemaitre
approved these changes
Feb 27, 2019
Member
|
I think that @jorisvandenbossche has a good point. Otherwise it would be really good to merge this. |
Member
Author
|
Happy to remove that, but wasn't sure if it requires deprecation? |
Member
Author
|
with removing the parameter? and do a deprecation cycle? |
Member
Author
|
we can always remove / deprecate this later. two check marks -> green button |
xhluca
pushed a commit
to xhluca/scikit-learn
that referenced
this pull request
Apr 28, 2019
* don't warn on changing dtypes in scalers * remove tests for dtype warnings * len(False) > len(True) pep8
xhluca
pushed a commit
to xhluca/scikit-learn
that referenced
this pull request
Apr 28, 2019
)" This reverts commit 69a9299.
xhluca
pushed a commit
to xhluca/scikit-learn
that referenced
this pull request
Apr 28, 2019
)" This reverts commit 69a9299.
koenvandevelde
pushed a commit
to koenvandevelde/scikit-learn
that referenced
this pull request
Jul 12, 2019
* don't warn on changing dtypes in scalers * remove tests for dtype warnings * len(False) > len(True) pep8
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Don't warn on changing dtypes in scalers. It's really annoying and doesn't seem very useful.