[MRG] TST make cython an optional test dependency#13277
Merged
glemaitre merged 1 commit intoscikit-learn:masterfrom Feb 26, 2019
Merged
[MRG] TST make cython an optional test dependency#13277glemaitre merged 1 commit intoscikit-learn:masterfrom
glemaitre merged 1 commit intoscikit-learn:masterfrom
Conversation
qinhanmin2014
approved these changes
Feb 26, 2019
xhluca
pushed a commit
to xhluca/scikit-learn
that referenced
this pull request
Apr 28, 2019
xhluca
pushed a commit
to xhluca/scikit-learn
that referenced
this pull request
Apr 28, 2019
…)" This reverts commit 5182c15.
xhluca
pushed a commit
to xhluca/scikit-learn
that referenced
this pull request
Apr 28, 2019
…)" This reverts commit 5182c15.
koenvandevelde
pushed a commit
to koenvandevelde/scikit-learn
that referenced
this pull request
Jul 12, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I tested locally that I can launch the tests in a new virtualenv without cython installed. We could update one of our CI job to uninstall cython prior to launching the tests but I don't think it's worth it so I would rather not to :)