Delete wrapper function optics around OPTICS#13271
Merged
adrinjalali merged 2 commits intoscikit-learn:masterfrom Feb 26, 2019
Merged
Delete wrapper function optics around OPTICS#13271adrinjalali merged 2 commits intoscikit-learn:masterfrom
adrinjalali merged 2 commits intoscikit-learn:masterfrom
Conversation
optics () is a simple wrapper around the OPTICS class which instantiates the class and calls fit. This wrapper exists for DBSCAN or K-Means but not for all clustering methods. For code homogeneity, I am deleting this function.
Member
|
tests failing? |
Member
|
This also fixes #11568 |
Previous commit forgot to delete the optics wrapper from the cluster module list. So the test testing the presence of modules failed.
Contributor
Author
|
I forgot to delete the |
qinhanmin2014
approved these changes
Feb 26, 2019
Member
qinhanmin2014
left a comment
There was a problem hiding this comment.
So the final decision is to split it in a separate PR ? OK then.
Member
|
yeah I'm happy to have this separate. LGTM as well. |
adrinjalali
approved these changes
Feb 26, 2019
Member
|
Thanks @AssiaBen :) |
xhluca
pushed a commit
to xhluca/scikit-learn
that referenced
this pull request
Apr 28, 2019
* Delete wrapper function optics around OPTICS optics () is a simple wrapper around the OPTICS class which instantiates the class and calls fit. This wrapper exists for DBSCAN or K-Means but not for all clustering methods. For code homogeneity, I am deleting this function. * delete optics wrapper from cluster module list Previous commit forgot to delete the optics wrapper from the cluster module list. So the test testing the presence of modules failed.
koenvandevelde
pushed a commit
to koenvandevelde/scikit-learn
that referenced
this pull request
Jul 12, 2019
* Delete wrapper function optics around OPTICS optics () is a simple wrapper around the OPTICS class which instantiates the class and calls fit. This wrapper exists for DBSCAN or K-Means but not for all clustering methods. For code homogeneity, I am deleting this function. * delete optics wrapper from cluster module list Previous commit forgot to delete the optics wrapper from the cluster module list. So the test testing the presence of modules failed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #11568.
@adrinjalali
opticsis a simple wrapper around theOPTICSclass which instantiates theclass and calls fit. This wrapper exists for DBSCAN or K-Means but not for all
clustering methods. For code homogeneity, I am deleting this function. I delete the documentation references to it.