TST test was relying on arch-dependent casting of NaN#13265
Merged
glemaitre merged 1 commit intoscikit-learn:masterfrom Feb 26, 2019
Merged
TST test was relying on arch-dependent casting of NaN#13265glemaitre merged 1 commit intoscikit-learn:masterfrom
glemaitre merged 1 commit intoscikit-learn:masterfrom
Conversation
Member
Author
|
Cast from NaN to int on linux returned a very negative number. On ARM returned 0. |
rth
approved these changes
Feb 25, 2019
jnothman
added a commit
to jnothman/scikit-learn
that referenced
this pull request
Feb 26, 2019
xhluca
pushed a commit
to xhluca/scikit-learn
that referenced
this pull request
Apr 28, 2019
xhluca
pushed a commit
to xhluca/scikit-learn
that referenced
this pull request
Apr 28, 2019
…t-learn#13265)" This reverts commit 9d00316.
xhluca
pushed a commit
to xhluca/scikit-learn
that referenced
this pull request
Apr 28, 2019
…t-learn#13265)" This reverts commit 9d00316.
koenvandevelde
pushed a commit
to koenvandevelde/scikit-learn
that referenced
this pull request
Jul 12, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #13049. Tested on ARM