DOC Avoid training/predicting on random dataset in the tutorial#13234
Merged
qinhanmin2014 merged 2 commits intoscikit-learn:masterfrom Mar 4, 2019
qinhanmin2014:tutorial
Merged
DOC Avoid training/predicting on random dataset in the tutorial#13234qinhanmin2014 merged 2 commits intoscikit-learn:masterfrom qinhanmin2014:tutorial
qinhanmin2014 merged 2 commits intoscikit-learn:masterfrom
qinhanmin2014:tutorial
Conversation
Member
|
tests failing, but looks good. |
Member
Author
thanks for the review, test failures are irrelevant, CIs are green now :) |
Member
Author
|
I think I have enough confidence to merge this. |
xhluca
pushed a commit
to xhluca/scikit-learn
that referenced
this pull request
Apr 28, 2019
xhluca
pushed a commit
to xhluca/scikit-learn
that referenced
this pull request
Apr 28, 2019
…al (scikit-learn#13234)" This reverts commit 324ab2e.
xhluca
pushed a commit
to xhluca/scikit-learn
that referenced
this pull request
Apr 28, 2019
…al (scikit-learn#13234)" This reverts commit 324ab2e.
koenvandevelde
pushed a commit
to koenvandevelde/scikit-learn
that referenced
this pull request
Jul 12, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #13221 (comment)