[MRG] Fix #13152 - pypy failure in doctest of extract_patches_2d#13178
Closed
fferrin wants to merge 3 commits intoscikit-learn:masterfrom
Closed
[MRG] Fix #13152 - pypy failure in doctest of extract_patches_2d#13178fferrin wants to merge 3 commits intoscikit-learn:masterfrom
fferrin wants to merge 3 commits intoscikit-learn:masterfrom
Conversation
…d: Change selected image
…d: Fix white line
Contributor
Author
|
I just realized that nothing has changed. I do not know what the problem was, but if it persists, it's because of the image index. |
Member
|
So it's a random failure? That's really weird. |
Member
|
While working on azure pipelines, I noticed this failure once on linux python 3.7. It has not appeared again. |
Member
|
Yes, I also got it once locally with CPython 3.7. It's not specific to PyPy. |
Member
Currently, CI on master fails because of it https://dev.azure.com/the-real-scikit-learn/scikit-learn/_build/results?buildId=69 and we are also seeing it e.g. in #13234 |
Member
|
I am looking into it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Fixes #13152
What does this implement/fix? Explain your changes.
There was an error in the docstring of
feature_extraction.image.extract_patches_2dfunction when checking the values of the patches. That was because it was using the wrong image.Any other comments?