[MRG] MAINT: Continue moving from CBLAS to scipy cython blas#13084
Merged
ogrisel merged 9 commits intoscikit-learn:masterfrom Feb 20, 2019
Merged
[MRG] MAINT: Continue moving from CBLAS to scipy cython blas#13084ogrisel merged 9 commits intoscikit-learn:masterfrom
ogrisel merged 9 commits intoscikit-learn:masterfrom
Conversation
agramfort
approved these changes
Feb 4, 2019
Member
Author
|
ping @ogrisel maybe you want to take a look :) |
ogrisel
approved these changes
Feb 20, 2019
Member
ogrisel
left a comment
There was a problem hiding this comment.
LGTM. The cholesky_delete call is covered by the tests of least_angle.py (I checked the coverage report).
xhluca
pushed a commit
to xhluca/scikit-learn
that referenced
this pull request
Apr 28, 2019
xhluca
pushed a commit
to xhluca/scikit-learn
that referenced
this pull request
Apr 28, 2019
…cikit-learn#13084)" This reverts commit fa0c006.
xhluca
pushed a commit
to xhluca/scikit-learn
that referenced
this pull request
Apr 28, 2019
…cikit-learn#13084)" This reverts commit fa0c006.
jackmitch
pushed a commit
to jackmitch/scikit-learn
that referenced
this pull request
Jul 2, 2019
koenvandevelde
pushed a commit
to koenvandevelde/scikit-learn
that referenced
this pull request
Jul 12, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Another step toward #11638
This PR is a continuation of #12732.
There were BLAS calls in the following cython files:
weight_vector.pyx,cd_fast.pyxand_k_means.pyx.There were also BLAS calls in the C file
cholesky_delete.h. I decided to move (using fused types) the only function there to cython inarrayfuncs.pyxwhere there was a python wrapper for it.I added
rotanrotgto the cython blas functions which I forgot in [MRG] Use Scipy cython BLAS API instead of bundled CBLAS #12732 because I didn't check C files...I also removed linking to blas libs in some setups for modules which didn't call BLAS functions.
The only remaining calls to bundled CBLAS in sklearn appear in
tron.cpp, used in liblinear. They can't be replaced easily by calls to scipy cython blas because the calls to BLAS are not from cython files but from C files.