Skip to content

MAINT Pin numpy version 1.5.* for pypy#13011

Merged
adrinjalali merged 3 commits intoscikit-learn:masterfrom
rth:pypy-numpy-1.6
Jan 18, 2019
Merged

MAINT Pin numpy version 1.5.* for pypy#13011
adrinjalali merged 3 commits intoscikit-learn:masterfrom
rth:pypy-numpy-1.6

Conversation

@rth
Copy link
Copy Markdown
Member

@rth rth commented Jan 18, 2019 •
edited
Loading

Closes #13009

Temporarily revert to numpy 1.5.x for PyPy due to numpy/numpy#12740

adrinjalali
adrinjalali reviewed Jan 18, 2019
View reviewed changes
build_tools/circle/build_test_pypy.sh
which python

pip install --extra-index https://antocuni.github.io/pypy-wheels/ubuntu numpy Cython pytest
pip install --extra-index https://antocuni.github.io/pypy-wheels/ubuntu "numpy==1.5.*" Cython pytest
Copy link
Copy Markdown
Member

@adrinjalali adrinjalali Jan 18, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe a comment why we're having this change?

Or maybe, check the pypy version, if it's the buggy version do numpy 1.5, if not, latest?

qinhanmin2014
qinhanmin2014 approved these changes Jan 18, 2019
View reviewed changes
Copy link
Copy Markdown
Member

@qinhanmin2014 qinhanmin2014 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 to add some comments so that we can revert the change after pypi releases.

@rth
Copy link
Copy Markdown
Member Author

rth commented Jan 18, 2019

Thanks. Added the comment.

Or maybe, check the pypy version, if it's the buggy version do numpy 1.5, if not, latest?

As far as I understand, the issue is with numpy not PyPy (that hasn't changed): We use a fixed version of PyPy3 v6.0.0 here.

@qinhanmin2014
Copy link
Copy Markdown
Member

qinhanmin2014 commented Jan 18, 2019

As far as I understand, the issue is with numpy not PyPy (that hasn't changed): We use a fixed version of PyPy3 v6.0.0 here.

@rth You mean numpy will fix the issue? I saw the following comment in numpy/numpy#12740:
You need to either use a nightly build of PyPy from http://buildbot.pypy.org/nightly/py3.5/pypy-c-jit-latest-linux64.tar.bz2 or pin NumPy to 1.15.4. The last released pypy3 has a bug that makes module read-only. In PR #12594 there is a script to download, unpack, and setup that nightly
So numpy thinks the issue is with pypy and pypy already fixed it?

@qinhanmin2014
Copy link
Copy Markdown
Member

qinhanmin2014 commented Jan 18, 2019

And I think we need to provide an option to run pypi in PRs (like [scipy-dev])

@rth
Copy link
Copy Markdown
Member Author

rth commented Jan 18, 2019 •
edited
Loading

You are right, I read it a bit quickly. Well, I think my note to revert the pinning is still kind of valid.

And I think we need to provide an option to run pypi in PRs (like [scipy-dev])

Agreed, but probably not in this PR..

@qinhanmin2014
Copy link
Copy Markdown
Member

qinhanmin2014 commented Jan 18, 2019

Agreed, but probably not in this PR..

I'll open an issue.

@adrinjalali
Copy link
Copy Markdown
Member

adrinjalali commented Jan 18, 2019

If not checking the pypy version, then I guess we should have an issue saying "revert change xxx once pypy fixes yyy". I just don't want us to forget to revert this.

@qinhanmin2014
Copy link
Copy Markdown
Member

qinhanmin2014 commented Jan 18, 2019

If not checking the pypy version, then I guess we should have an issue saying "revert change xxx once pypy fixes yyy". I just don't want us to forget to revert this.

No strong feelings. You can open one (or keep the original issue open) but I guess this won't block us from merging the PR.

@rth
Copy link
Copy Markdown
Member Author

rth commented Jan 18, 2019

If not checking the pypy version

Well, it's an issue between pypy and numpy, so if version checking happens it should take place in numpy 1.6.1 IMO.

I updated the comment to reflect that this will be fixed in the next pypy release.

@adrinjalali adrinjalali merged commit 9ce9b24 into scikit-learn:master Jan 18, 2019
@adrinjalali
Copy link
Copy Markdown
Member

adrinjalali commented Jan 18, 2019

Thanks @rth

@rth rth deleted the pypy-numpy-1.6 branch January 22, 2019 21:08
@rth rth mentioned this pull request Jan 22, 2019
Merged
thomasjpfan pushed a commit to thomasjpfan/scikit-learn that referenced this pull request Feb 7, 2019
@rth @thomasjpfan
MAINT Pin numpy version 1.5.* for pypy (scikit-learn#13011)
fa3cbc8 
* Pin numpy version for pypy

* Add comment

* Updated comment to wait for next pypy release
xhluca pushed a commit to xhluca/scikit-learn that referenced this pull request Apr 28, 2019
@rth
MAINT Pin numpy version 1.5.* for pypy (scikit-learn#13011)
29daa36 
* Pin numpy version for pypy

* Add comment

* Updated comment to wait for next pypy release
xhluca pushed a commit to xhluca/scikit-learn that referenced this pull request Apr 28, 2019
Revert "MAINT Pin numpy version 1.5.* for pypy (scikit-learn#13011)"
f7b6ec4 
This reverts commit 29daa36.
xhluca pushed a commit to xhluca/scikit-learn that referenced this pull request Apr 28, 2019
Revert "MAINT Pin numpy version 1.5.* for pypy (scikit-learn#13011)"
c70879c 
This reverts commit 29daa36.
koenvandevelde pushed a commit to koenvandevelde/scikit-learn that referenced this pull request Jul 12, 2019
@rth @koenvandevelde
MAINT Pin numpy version 1.5.* for pypy (scikit-learn#13011)
b6e27ef 
* Pin numpy version for pypy

* Add comment

* Updated comment to wait for next pypy release
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@adrinjalali adrinjalali adrinjalali approved these changes

+1 more reviewer

@qinhanmin2014 qinhanmin2014 qinhanmin2014 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@rth @qinhanmin2014 @adrinjalali