Skip to content

[MRG] DOC: Links cluster.optics#12981

Merged
qinhanmin2014 merged 1 commit intoscikit-learn:masterfrom
thomasjpfan:dbscan_link_fix
Jan 14, 2019
Merged

[MRG] DOC: Links cluster.optics#12981
qinhanmin2014 merged 1 commit intoscikit-learn:masterfrom
thomasjpfan:dbscan_link_fix

Conversation

@thomasjpfan
Copy link
Copy Markdown
Member

This PR enables the link to cluster.optics in dbscan's docstring.

@adrinjalali
Copy link
Copy Markdown
Member

This means we actually need to get our act together and finish OPTICS for v0.21 :P

otherwise LGTM!

@qinhanmin2014
Copy link
Copy Markdown
Member

I'll try to go back to the OPTICS issues at the end of this month (after the end of this semester). Maybe we can discuss these issues during the sprint.

@qinhanmin2014 qinhanmin2014 merged commit 7ee321f into scikit-learn:master Jan 14, 2019
@qinhanmin2014
Copy link
Copy Markdown
Member

I'll try to go back to the OPTICS issues at the end of this month (after the end of this semester). Maybe we can discuss these issues during the sprint.

Personally I'm still not satisfied with the API design we've figured out (i.e., I'll vote +0, not +1). We might need more discussions.

xhluca pushed a commit to xhluca/scikit-learn that referenced this pull request Apr 28, 2019
xhluca pushed a commit to xhluca/scikit-learn that referenced this pull request Apr 28, 2019
xhluca pushed a commit to xhluca/scikit-learn that referenced this pull request Apr 28, 2019
koenvandevelde pushed a commit to koenvandevelde/scikit-learn that referenced this pull request Jul 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants