MAINT Remove unused utils.fixes#12928
Merged
jnothman merged 4 commits intoscikit-learn:masterfrom Jan 8, 2019
Merged
Conversation
Member
This reverts commit 9a36c23.
Member
Author
|
Thanks, I didn't see that PR. Reverted the last commit which should only leave changes relative to unused |
adrinjalali
approved these changes
Jan 6, 2019
Member
adrinjalali
left a comment
There was a problem hiding this comment.
I haven't checked for completeness, otherwise LGTM!
jnothman
approved these changes
Jan 8, 2019
Member
|
Thanks @rth |
xhluca
pushed a commit
to xhluca/scikit-learn
that referenced
this pull request
Apr 28, 2019
This continues the work done in scikit-learn#12639 on dropping the python 2 support by, - ~~removing unnecessary `from __future__` imports~~ - removing unused `sklearn.utils.fixes` assuming we can agree in scikit-learn#12927 that `sklearn.utils.fixes` are private as was stated e.g. in scikit-learn#6616 (comment)
xhluca
pushed a commit
to xhluca/scikit-learn
that referenced
this pull request
Apr 28, 2019
This reverts commit 07ce93b.
xhluca
pushed a commit
to xhluca/scikit-learn
that referenced
this pull request
Apr 28, 2019
This reverts commit 07ce93b.
koenvandevelde
pushed a commit
to koenvandevelde/scikit-learn
that referenced
this pull request
Jul 12, 2019
This continues the work done in scikit-learn#12639 on dropping the python 2 support by, - ~~removing unnecessary `from __future__` imports~~ - removing unused `sklearn.utils.fixes` assuming we can agree in scikit-learn#12927 that `sklearn.utils.fixes` are private as was stated e.g. in scikit-learn#6616 (comment)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This continues the work done in #12639 on dropping the python 2 support by,
removing unnecessaryfrom __future__importssklearn.utils.fixesassuming we can agree in RFC Definition of public API #12927 thatsklearn.utils.fixesare private as was stated e.g. in Public vs. private utils again #6616 (comment)