Skip to content

[MRG+1] Fix several DeprecationWarning: invalid escape sequence in examples#12924

Merged
qinhanmin2014 merged 2 commits intoscikit-learn:masterfrom
BoboTiG:fix-invalid-seq-warnings
Jan 5, 2019
Merged

[MRG+1] Fix several DeprecationWarning: invalid escape sequence in examples#12924
qinhanmin2014 merged 2 commits intoscikit-learn:masterfrom
BoboTiG:fix-invalid-seq-warnings

Conversation

@BoboTiG
Copy link
Copy Markdown
Contributor

@BoboTiG BoboTiG commented Jan 4, 2019

Reference Issues/PRs

None.

What does this implement/fix? Explain your changes.

This fixes several DeprecationWarning: invalid sequence in examples.

Any other comments?

None.

Copy link
Copy Markdown
Member

@adrinjalali adrinjalali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @BoboTiG !

@adrinjalali adrinjalali changed the title Fix several DeprecationWarning: invalid escape sequence in examples [MRG+1] Fix several DeprecationWarning: invalid escape sequence in examples Jan 4, 2019
Copy link
Copy Markdown
Member

@qinhanmin2014 qinhanmin2014 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @BoboTiG
We'll need to handle these issues in the whole repo.

@qinhanmin2014 qinhanmin2014 merged commit 2df5945 into scikit-learn:master Jan 5, 2019
@BoboTiG BoboTiG deleted the fix-invalid-seq-warnings branch January 5, 2019 07:54
@BoboTiG
Copy link
Copy Markdown
Contributor Author

BoboTiG commented Jan 5, 2019

My pleasure :)

I already checked the whole repos but found nothing. FYI I used this command:

PYTHONWARNINGS=all python -m compileall . > /dev/null

@qinhanmin2014
Copy link
Copy Markdown
Member

I already checked the whole repos but found nothing. FYI I used this command:

Thanks for your confirmation :)

adrinjalali pushed a commit to adrinjalali/scikit-learn that referenced this pull request Jan 7, 2019
jnothman pushed a commit to jnothman/scikit-learn that referenced this pull request Feb 19, 2019
xhluca pushed a commit to xhluca/scikit-learn that referenced this pull request Apr 28, 2019
xhluca pushed a commit to xhluca/scikit-learn that referenced this pull request Apr 28, 2019
xhluca pushed a commit to xhluca/scikit-learn that referenced this pull request Apr 28, 2019
koenvandevelde pushed a commit to koenvandevelde/scikit-learn that referenced this pull request Jul 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants