Skip to content

[MRG] Documentation/svc documentation references#12859

Merged
jnothman merged 10 commits intoscikit-learn:masterfrom
tashay:documentation/SVC
Jan 13, 2019
Merged

[MRG] Documentation/svc documentation references#12859
jnothman merged 10 commits intoscikit-learn:masterfrom
tashay:documentation/SVC

Conversation

@tashay
Copy link
Copy Markdown
Contributor

@tashay tashay commented Dec 24, 2018 •
edited by jnothman
Loading

Reference Issues/PRs

This PR is a continuation of the work on and resolves #12217.

What does this implement/fix? Explain your changes.

This PR adds references for SVC

Any other comments?

#wimlds
cc: @reshamas

@tashay tashay changed the title Documentation/svc Documentation/svc documentation references Dec 24, 2018
NicolasHug
NicolasHug reviewed Dec 24, 2018
View reviewed changes
sklearn/svm/classes.py Outdated

probA_ : array, shape = [n_class * (n_class-1) / 2]
probB_ : array, shape = [n_class * (n_class-1) / 2]

Copy link
Copy Markdown
Member

@NicolasHug NicolasHug Dec 24, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need to skip line

sklearn/svm/classes.py Outdated
Notes

References
-----
Copy link
Copy Markdown
Member

@NicolasHug NicolasHug Dec 24, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be:

References
----------

sklearn/svm/classes.py Outdated
LinearSVC for more comparison element.

Notes

Copy link
Copy Markdown
Member

@NicolasHug NicolasHug Dec 24, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need to skip line

sklearn/svm/classes.py Outdated
**References:**
`LIBSVM: A Library for Support Vector Machines
<http://www.csie.ntu.edu.tw/~cjlin/papers/libsvm.pdf>`__
.. [1]`LIBSVM: A Library for Support Vector Machines
Copy link
Copy Markdown
Member

@NicolasHug NicolasHug Dec 24, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs blank space after [1]

@reshamas
Copy link
Copy Markdown
Member

reshamas commented Jan 5, 2019

@NicolasHug
Any more feedback to share with updated commit?
And, do we know who the other reviewer will be on this PR?

NicolasHug
NicolasHug reviewed Jan 5, 2019
View reviewed changes
@NicolasHug @tashay
Apply suggestions from code review
c6de020 
Co-Authored-By: tashay <tashay.g@gmail.com>
@tashay tashay changed the title Documentation/svc documentation references [MRG] Documentation/svc documentation references Jan 5, 2019
jnothman
jnothman reviewed Jan 7, 2019
View reviewed changes
sklearn/svm/classes.py Outdated
information on the multiclass case and training procedure see section
8 of LIBSVM: A Library for Support Vector Machines (in References)
for more.
8 of LIBSVM: A Library for Support Vector Machines [1]_.
Copy link
Copy Markdown
Member

@jnothman jnothman Jan 7, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think [2]_ should also be cited somewhere. Perhaps under the probability parameter description above.

Copy link
Copy Markdown
Contributor Author

@tashay tashay Jan 10, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

jnothman
jnothman approved these changes Jan 10, 2019
View reviewed changes
Copy link
Copy Markdown
Member

@jnothman jnothman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise LGTM

sklearn/svm/classes.py Outdated
for more.
where ``probA_`` and ``probB_`` are learned from the dataset [2]_. For
more information on the multiclass case and training procedure see
section 8 of LIBSVM: A Library for Support Vector Machines [1]_.
Copy link
Copy Markdown
Member

@jnothman jnothman Jan 10, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

section 8 of [1]_ should suffice?

@jnothman jnothman merged commit 0cf8a16 into scikit-learn:master Jan 13, 2019
@jnothman
Copy link
Copy Markdown
Member

jnothman commented Jan 13, 2019

Thanks @tashay!

@reshamas
Copy link
Copy Markdown
Member

reshamas commented Jan 13, 2019

yeah! thank you @tashay 👍, as well as @NicolasHug and @jnothman

And thanks to @cynco too.

@tashay tashay deleted the documentation/SVC branch January 13, 2019 20:48
jnothman pushed a commit to jnothman/scikit-learn that referenced this pull request Feb 19, 2019
@tashay @jnothman
DOC references for probabilistic SVC (scikit-learn#12859)
8963e71
xhluca pushed a commit to xhluca/scikit-learn that referenced this pull request Apr 28, 2019
@tashay
DOC references for probabilistic SVC (scikit-learn#12859)
e89aadf
xhluca pushed a commit to xhluca/scikit-learn that referenced this pull request Apr 28, 2019
Revert "DOC references for probabilistic SVC (scikit-learn#12859)"
ffc5fe6 
This reverts commit e89aadf.
xhluca pushed a commit to xhluca/scikit-learn that referenced this pull request Apr 28, 2019
Revert "DOC references for probabilistic SVC (scikit-learn#12859)"
4012a5d 
This reverts commit e89aadf.
koenvandevelde pushed a commit to koenvandevelde/scikit-learn that referenced this pull request Jul 12, 2019
@tashay @koenvandevelde
DOC references for probabilistic SVC (scikit-learn#12859)
4d473f5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jnothman jnothman jnothman approved these changes

+1 more reviewer

@NicolasHug NicolasHug NicolasHug left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@tashay @reshamas @jnothman @NicolasHug @cynco