Skip to content

improve TfidfVectorizer documentation#12811

Closed
reshamas wants to merge 12 commits intoscikit-learn:masterfrom
reshamas:tdidf_doc
Closed

improve TfidfVectorizer documentation#12811
reshamas wants to merge 12 commits intoscikit-learn:masterfrom
reshamas:tdidf_doc

Conversation

@reshamas
Copy link
Copy Markdown
Member

Referencing PR / Issue

This closes #12204
This also closes #6766 and closes #9369

Note

This adds more information in the TfidfVectorizer documentation. It now includes comments about CountVectorizer and TfidfTransformer.

cc: @blooraspberry
#wimlds

@reshamas reshamas changed the title tfidfvectorizer documentation improve TfidfVectorizer documentation Dec 18, 2018
@reshamas
Copy link
Copy Markdown
Member Author

I was supposed to push this file: sklearn/feature_extraction/text.py
but it looks like I pushed another file: sklearn/decomposition/dict_learning.py

Not sure how to clean this up? When I type git push origin tdidf_doc, I get this:

(sklearndev) ➜  scikit-learn git:(tdidf_doc) git push origin tdidf_doc                      
To github.com:reshamas/scikit-learn.git
 ! [rejected]            tdidf_doc -> tdidf_doc (non-fast-forward)
error: failed to push some refs to 'git@github.com:reshamas/scikit-learn.git'
hint: Updates were rejected because the tip of your current branch is behind
hint: its remote counterpart. Integrate the remote changes (e.g.
hint: 'git pull ...') before pushing again.
hint: See the 'Note about fast-forwards' in 'git push --help' for details.

@jnothman
Copy link
Copy Markdown
Member

here a force push (git push -f) might be approprite

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

TfidfVectorizer documentation doesn't track TfidfTransformer

3 participants