[MRG] tfidfvectorizer documentation#12204
Closed
blooraspberry wants to merge 2 commits intoscikit-learn:masterfrom
Closed
[MRG] tfidfvectorizer documentation#12204blooraspberry wants to merge 2 commits intoscikit-learn:masterfrom
blooraspberry wants to merge 2 commits intoscikit-learn:masterfrom
Conversation
amueller
reviewed
Sep 29, 2018
sklearn/feature_extraction/text.py
Outdated
|
|
||
| CountVectorizer converts a collection of text documents to a matrix of token counts. | ||
|
|
||
| TfidfTransformer then converts the count matrix from CountVectorizer to a normalized tf-idf representation. Tf is term frequency, and idf is inverse document frequency. This is a common way to calculate the count of a word relative to the appearance of a ducument. |
Member
There was a problem hiding this comment.
Can you make sure to break the lines please?
| TfidfTransformer then converts the count matrix from CountVectorizer to a normalized tf-idf representation. Tf is term frequency, and idf is inverse document frequency. This is a common way to calculate the count of a word relative to the appearance of a ducument. | ||
|
|
||
| The formula that is used to compute the tf-idf of term t is | ||
| tf-idf(d, t) = tf(t) * idf(d, t), and the idf is computed as |
Member
There was a problem hiding this comment.
I think the other documentation has some formatting for these, can you make sure to copy the code, not the rendering?
Member
|
Can you please reference the issues and PRs this is addressing in the description? Then merging this will close these. |
jnothman
approved these changes
Sep 30, 2018
qinhanmin2014
approved these changes
Sep 30, 2018
Member
There was a problem hiding this comment.
@blooraspberry I've restarted Travis for you and there're flake8 errors. Please correct them according to https://travis-ci.org/scikit-learn/scikit-learn/jobs/435054659
Member
Member
|
Travis output is unreadable, so here is what needs to be fixed in text.py: |
Contributor
|
Hello @blooraspberry , Thank you for participating in the WiMLDS/scikit sprint. We would love to merge all the PRs that were submitted. It would be great if you could follow up on the work that you started! For the PR you submitted, would you please update and re-submit? Please include #wimlds in your PR conversation. Any questions:
cc: @reshamas |
Author
|
Hi Sergul,
Sorry I just saw this email -- didn't realize my github is connected to
another email account. I'll take a look soon.
Sharon
…On Sun, Nov 11, 2018 at 11:29 AM Sergul Aydore ***@***.***> wrote:
Hello @blooraspberry <https://github.com/blooraspberry> ,
Thank you for participating in the WiMLDS/scikit sprint. We would love to
merge all the PRs that were submitted. It would be great if you could
follow up on the work that you started! For the PR you submitted, would you
please update and re-submit? Please include #wimlds in your PR conversation.
Any questions:
- see workflow
<https://github.com/WiMLDS/nyc-2018-scikit-sprint/blob/master/2_contributing_workflow.md>
for reference
- ask on this PR conversation or the issue tracker
- ask on wimlds gitter <https://gitter.im/scikit-learn/wimlds> with a
reference to this PR
cc: @reshamas <https://github.com/reshamas>
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#12204 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AQRDPCZ6Lbg7xfuDOTEPYeAq2fTiWU0_ks5uuFB8gaJpZM4XAlZG>
.
|
Member
|
@blooraspberry |
Member
|
I am working on this PR. |
This was referenced Dec 18, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #6766 and closes #9369
Reference Issues/PRs
What does this implement/fix? Explain your changes.
This adds more information in the TfidfVectorizer documentation. It now includes comments about CountVectorizer and TfidfTransformer.
Any other comments?