[MRG] Workaround limitation of cloudpickle under PyPy#12566
Merged
jnothman merged 1 commit intoscikit-learn:masterfrom Nov 13, 2018
Merged
[MRG] Workaround limitation of cloudpickle under PyPy#12566jnothman merged 1 commit intoscikit-learn:masterfrom
jnothman merged 1 commit intoscikit-learn:masterfrom
Conversation
Member
|
looks ok. Where's the failure in the tests? |
rth
approved these changes
Nov 12, 2018
| """Helper for the Parallel calls in KNeighborsMixin.kneighbors | ||
|
|
||
| The Cython method tree.query is not directly picklable by cloudpickle | ||
| under PyPy. |
Member
There was a problem hiding this comment.
Interesting that this works while pickling directly fails. I don't really have a good understanding of cloudpickle (or pickling in general) to have much to say about this. LGTM since it fixes the original failure.
jnothman
approved these changes
Nov 13, 2018
Member
|
Not sure if this deserves a what's new. I'm going with no. |
thoo
added a commit
to thoo/scikit-learn
that referenced
this pull request
Nov 13, 2018
…ybutton * upstream/master: Fix max_depth overshoot in BFS expansion of trees (scikit-learn#12344) TST don't test utils.fixes docstrings (scikit-learn#12576) DOC Fix typo (scikit-learn#12563) FIX Workaround limitation of cloudpickle under PyPy (scikit-learn#12566) MNT bare asserts (scikit-learn#12571) FIX incorrect error when OneHotEncoder.transform called prior to fit (scikit-learn#12443)
thoo
pushed a commit
to thoo/scikit-learn
that referenced
this pull request
Nov 13, 2018
thoo
added a commit
to thoo/scikit-learn
that referenced
this pull request
Nov 13, 2018
…ikit-learn into add_codeblock_copybutton * 'add_codeblock_copybutton' of https://github.com/thoo/scikit-learn: Move an extension under sphinx_copybutton/ Move css/js file under sphinxext/ Fix max_depth overshoot in BFS expansion of trees (scikit-learn#12344) TST don't test utils.fixes docstrings (scikit-learn#12576) DOC Fix typo (scikit-learn#12563) FIX Workaround limitation of cloudpickle under PyPy (scikit-learn#12566) MNT bare asserts (scikit-learn#12571) FIX incorrect error when OneHotEncoder.transform called prior to fit (scikit-learn#12443) Retrigger travis:max time limit error DOC: Clarify `cv` parameter description in `GridSearchCV` (scikit-learn#12495) FIX remove FutureWarning in _object_dtype_isnan and add test (scikit-learn#12567) DOC Add 's' to "correspond" in docs for Hamming Loss. (scikit-learn#12565) EXA Fix comment in plot-iris-logistic example (scikit-learn#12564) FIX stop words validation in text vectorizers with custom preprocessors / tokenizers (scikit-learn#12393) DOC Add skorch to related projects (scikit-learn#12561) MNT Don't change self.n_values in OneHotEncoder.fit (scikit-learn#12286) MNT Remove unused assert_true imports (scikit-learn#12560) TST autoreplace assert_true(...==...) with plain assert (scikit-learn#12547) DOC: add a testimonial from JP Morgan (scikit-learn#12555)
thoo
pushed a commit
to thoo/scikit-learn
that referenced
this pull request
Nov 14, 2018
jnothman
pushed a commit
to jnothman/scikit-learn
that referenced
this pull request
Nov 14, 2018
jnothman
pushed a commit
to jnothman/scikit-learn
that referenced
this pull request
Nov 14, 2018
xhluca
pushed a commit
to xhluca/scikit-learn
that referenced
this pull request
Apr 28, 2019
xhluca
pushed a commit
to xhluca/scikit-learn
that referenced
this pull request
Apr 28, 2019
…earn#12566)" This reverts commit 4b97841.
xhluca
pushed a commit
to xhluca/scikit-learn
that referenced
this pull request
Apr 28, 2019
…earn#12566)" This reverts commit 4b97841.
koenvandevelde
pushed a commit
to koenvandevelde/scikit-learn
that referenced
this pull request
Jul 12, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a fix for #12554.
I have tried to have a look as at the dissembled pickle payload of the example in #12554 (comment) to try to understand what is the cause of the problem and how it differs from the case where we we use pickle with PyPy or cloudpickle with CPython (which both work) but I don't know where to start. But I am lost in PyPy internals
So instead here is a simple workaround.