[MRG] New Feature: VotingRegressor#12513
Merged
jnothman merged 44 commits intoscikit-learn:masterfrom Apr 10, 2019
stsouko:master
Merged
[MRG] New Feature: VotingRegressor#12513jnothman merged 44 commits intoscikit-learn:masterfrom stsouko:master
jnothman merged 44 commits intoscikit-learn:masterfrom
stsouko:master
Conversation
added 4 commits
November 3, 2018 21:23
tests done. this is fork of PR #10868 which is not being finalized for a long time.
flake fixed.
Contributor
|
Please add the [WIP] tag. Remember add [MRG] when you finish. |
added 3 commits
November 6, 2018 17:11
# Conflicts: # doc/whats_new/v0.21.rst
eamanu
approved these changes
Nov 6, 2018
Contributor
eamanu
left a comment
There was a problem hiding this comment.
LGTM. I read the codes and IMO its ok.
jnothman
reviewed
Nov 6, 2018
Member
|
We have "Voting" classifier, but "Average" regressor. Should it be "AveragingRegressor" for consistency? |
jnothman
reviewed
Nov 6, 2018
added 2 commits
November 7, 2018 11:02
* AverageRegressor renamed to AveragingRegressor. * user guide fixed. * tests fixed. additional changes removed. * docstrings fixed. * user guide example plot fixed.
added 2 commits
November 9, 2018 15:11
test_notfitted extended. duplicates removed. DummyRegressor used. only for unique methods of AveragingRegressor tests added.
Author
|
I removed duplicate tests which checks common code. |
1 task
Author
|
@jnothman, tests fixed. VotingClassifier specific tests I can fix in new PR. |
jnothman
reviewed
Nov 13, 2018
NicolasHug
reviewed
Apr 7, 2019
Co-Authored-By: stsouko <stsouko@live.ru>
Co-Authored-By: stsouko <stsouko@live.ru>
Co-Authored-By: stsouko <stsouko@live.ru>
Co-Authored-By: stsouko <stsouko@live.ru>
Co-Authored-By: stsouko <stsouko@live.ru>
NicolasHug
approved these changes
Apr 9, 2019
Member
NicolasHug
left a comment
There was a problem hiding this comment.
Last comments, LGTM otherwise
NicolasHug
reviewed
Apr 10, 2019
Co-Authored-By: stsouko <stsouko@live.ru>
Member
|
Thanks @stsouko!! |
Member
|
Thanks @stsouko! |
Author
|
Thanks for the help in preparing PR |
6 tasks
jeremiedbb
pushed a commit
to jeremiedbb/scikit-learn
that referenced
this pull request
Apr 25, 2019
xhluca
pushed a commit
to xhluca/scikit-learn
that referenced
this pull request
Apr 28, 2019
xhluca
pushed a commit
to xhluca/scikit-learn
that referenced
this pull request
Apr 28, 2019
This reverts commit 4f137ed.
xhluca
pushed a commit
to xhluca/scikit-learn
that referenced
this pull request
Apr 28, 2019
This reverts commit 4f137ed.
koenvandevelde
pushed a commit
to koenvandevelde/scikit-learn
that referenced
this pull request
Jul 12, 2019
rghosh08
pushed a commit
to rghosh08/gemini-review-eval.
that referenced
this pull request
Mar 19, 2026
rghosh08
pushed a commit
to rghosh08/gemini-review-eval.
that referenced
this pull request
Mar 19, 2026
rghosh08
pushed a commit
to rghosh08/gemini-review-eval.
that referenced
this pull request
Mar 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Fixes #10743
What does this implement/fix? Explain your changes.
Following @amueller suggestion about adding sklearn.ensemble.AverageRegressor, this PR implements:
sklearn.ensemble.AverageRegressor
Associated units tests
Docstrings
Examples
Updates the documentation
Updates what's new
Any other comments?
This PR is inspired from work on
VotingClassifierand their associated unit-tests.this is fork of PR #10868 which is not being finalized for a long time.