[MRG] Fix segfault in AgglomerativeClustering with read-only mmaps#12485
Merged
amueller merged 1 commit intoscikit-learn:masterfrom Nov 6, 2018
Merged
Conversation
amueller
approved these changes
Oct 30, 2018
Member
|
Non-regression test? Common test? |
Member
Author
The failing test in #12483 is already a common test, and passes for other estimators but segfaults for this one with a given version of gcc in a particular environment. As I mentioned in #12483 (comment) the segfault is deterministic, but I was not able to reproduce it on passing that specific array to |
jnothman
approved these changes
Oct 31, 2018
Member
jnothman
left a comment
There was a problem hiding this comment.
Okay. Does it deserve a what's new in 0.20.1?
Member
Author
I'm not convinced it does. The segfault only happens in very peculiar environement (gcc version, but it doesn't segfault on other systems with the same gcc versions) that we are not able to exactly determine, and only happens for read-only arrays and I have a hard time believing that it would affect users in practice. There is no reason to use |
Member
|
think we don't need a whatsnew. |
thoo
added a commit
to thoo/scikit-learn
that referenced
this pull request
Nov 7, 2018
* upstream/master: joblib 0.13.0 (scikit-learn#12531) DOC tweak KMeans regarding cluster_centers_ convergence (scikit-learn#12537) DOC (0.21) Make sure plot_tree docs are generated and fix link in whatsnew (scikit-learn#12533) ALL Add HashingVectorizer to __all__ (scikit-learn#12534) BLD we should ensure continued support for joblib 0.11 (scikit-learn#12350) fix typo in whatsnew Fix dead link to numpydoc (scikit-learn#12532) [MRG] Fix segfault in AgglomerativeClustering with read-only mmaps (scikit-learn#12485) MNT (0.21) OPTiCS change the default `algorithm` to `auto` (scikit-learn#12529) FIX SkLearn `.score()` method generating error with Dask DataFrames (scikit-learn#12462) MNT KBinsDiscretizer.transform should not mutate _encoder (scikit-learn#12514)
thoo
added a commit
to thoo/scikit-learn
that referenced
this pull request
Nov 9, 2018
…ybutton * upstream/master: FIX YeoJohnson transform lambda bounds (scikit-learn#12522) [MRG] Additional Warnings in case OpenML auto-detected a problem with dataset (scikit-learn#12541) ENH Prefer threads for IsolationForest (scikit-learn#12543) joblib 0.13.0 (scikit-learn#12531) DOC tweak KMeans regarding cluster_centers_ convergence (scikit-learn#12537) DOC (0.21) Make sure plot_tree docs are generated and fix link in whatsnew (scikit-learn#12533) ALL Add HashingVectorizer to __all__ (scikit-learn#12534) BLD we should ensure continued support for joblib 0.11 (scikit-learn#12350) fix typo in whatsnew Fix dead link to numpydoc (scikit-learn#12532) [MRG] Fix segfault in AgglomerativeClustering with read-only mmaps (scikit-learn#12485) MNT (0.21) OPTiCS change the default `algorithm` to `auto` (scikit-learn#12529) FIX SkLearn `.score()` method generating error with Dask DataFrames (scikit-learn#12462) MNT KBinsDiscretizer.transform should not mutate _encoder (scikit-learn#12514)
thoo
pushed a commit
to thoo/scikit-learn
that referenced
this pull request
Nov 14, 2018
…cikit-learn#12485) This fixes a segfault in AgglomerativeClustering with read-only mmaps that happens inside `ward_tree` when calling `scipy.cluster.hierarchy.ward`. Closes scikit-learn#12483 (see the above issue for more details)
thoo
pushed a commit
to thoo/scikit-learn
that referenced
this pull request
Nov 14, 2018
…cikit-learn#12485) This fixes a segfault in AgglomerativeClustering with read-only mmaps that happens inside `ward_tree` when calling `scipy.cluster.hierarchy.ward`. Closes scikit-learn#12483 (see the above issue for more details)
jnothman
pushed a commit
to jnothman/scikit-learn
that referenced
this pull request
Nov 14, 2018
…cikit-learn#12485) This fixes a segfault in AgglomerativeClustering with read-only mmaps that happens inside `ward_tree` when calling `scipy.cluster.hierarchy.ward`. Closes scikit-learn#12483 (see the above issue for more details)
jnothman
pushed a commit
to jnothman/scikit-learn
that referenced
this pull request
Nov 14, 2018
…cikit-learn#12485) This fixes a segfault in AgglomerativeClustering with read-only mmaps that happens inside `ward_tree` when calling `scipy.cluster.hierarchy.ward`. Closes scikit-learn#12483 (see the above issue for more details)
xhluca
pushed a commit
to xhluca/scikit-learn
that referenced
this pull request
Apr 28, 2019
…cikit-learn#12485) This fixes a segfault in AgglomerativeClustering with read-only mmaps that happens inside `ward_tree` when calling `scipy.cluster.hierarchy.ward`. Closes scikit-learn#12483 (see the above issue for more details)
xhluca
pushed a commit
to xhluca/scikit-learn
that referenced
this pull request
Apr 28, 2019
…mmaps (scikit-learn#12485)" This reverts commit 940eb67.
xhluca
pushed a commit
to xhluca/scikit-learn
that referenced
this pull request
Apr 28, 2019
…mmaps (scikit-learn#12485)" This reverts commit 940eb67.
koenvandevelde
pushed a commit
to koenvandevelde/scikit-learn
that referenced
this pull request
Jul 12, 2019
…cikit-learn#12485) This fixes a segfault in AgglomerativeClustering with read-only mmaps that happens inside `ward_tree` when calling `scipy.cluster.hierarchy.ward`. Closes scikit-learn#12483 (see the above issue for more details)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes a segfault in AgglomerativeClustering with read-only mmaps that happens inside
ward_treewhen callingscipy.cluster.hierarchy.ward.Closes #12483
(see the above issue for more details)