EXA Calculate number of noise points in plot_dbscan.py#12428
Merged
jnothman merged 1 commit intoscikit-learn:masterfrom Oct 22, 2018
Merged
EXA Calculate number of noise points in plot_dbscan.py#12428jnothman merged 1 commit intoscikit-learn:masterfrom
jnothman merged 1 commit intoscikit-learn:masterfrom
Conversation
qinhanmin2014
approved these changes
Oct 21, 2018
Member
qinhanmin2014
left a comment
There was a problem hiding this comment.
LGTM, thanks @koenvandevelde
eamanu
approved these changes
Oct 22, 2018
jnothman
approved these changes
Oct 22, 2018
|
|
||
| # Number of clusters in labels, ignoring noise if present. | ||
| n_clusters_ = len(set(labels)) - (1 if -1 in labels else 0) | ||
| n_noise_ = list(labels).count(-1) |
Member
There was a problem hiding this comment.
The numpy idiom might rather be (labels == -1).sum(). But I suppose I'm fine either way
thoo
pushed a commit
to thoo/scikit-learn
that referenced
this pull request
Nov 14, 2018
jnothman
pushed a commit
to jnothman/scikit-learn
that referenced
this pull request
Nov 14, 2018
jnothman
pushed a commit
to jnothman/scikit-learn
that referenced
this pull request
Nov 14, 2018
xhluca
pushed a commit
to xhluca/scikit-learn
that referenced
this pull request
Apr 28, 2019
xhluca
pushed a commit
to xhluca/scikit-learn
that referenced
this pull request
Apr 28, 2019
This reverts commit 9b4ea74.
xhluca
pushed a commit
to xhluca/scikit-learn
that referenced
this pull request
Apr 28, 2019
This reverts commit 9b4ea74.
koenvandevelde
added a commit
to koenvandevelde/scikit-learn
that referenced
this pull request
Jul 12, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
What does this implement/fix? Explain your changes.
Any other comments?