MNT skip test falling on master in legacy platforms#12382
Merged
jnothman merged 4 commits intoscikit-learn:masterfrom Oct 15, 2018
qinhanmin2014:appveyor-failure
Merged
MNT skip test falling on master in legacy platforms#12382jnothman merged 4 commits intoscikit-learn:masterfrom qinhanmin2014:appveyor-failure
jnothman merged 4 commits intoscikit-learn:masterfrom
qinhanmin2014:appveyor-failure
Conversation
Member
|
I wonder why that operation is safe on 32-bit linux, but not on 32-bit windows. |
Member
|
Or rather, why linux does not require safe casting. |
jnothman
reviewed
Oct 15, 2018
| assert (count_nonzero(X_csr, axis=0, sample_weight=sample_weight).dtype == | ||
| count_nonzero(X_csr, axis=1, sample_weight=sample_weight).dtype) | ||
|
|
||
| # Check dtypes with large sparse matrices too |
Member
There was a problem hiding this comment.
Better than this (but perhaps still not ideal) would be to have this all in a try-except block, catching and passing if the error message contains "according to the rule 'safe'" and if np.intp().nbytes < 8.
Member
Author
There was a problem hiding this comment.
This LGTM from my side and I can't figure out a better solution.
This reverts commit db1dca4.
Member
Author
|
ping @jnothman CIs are green (though not sure why codecov fails), ready for another review :) |
Member
|
Codecov doesn't get stats from windows runs. |
jnothman
approved these changes
Oct 15, 2018
Member
|
I'm merging this to fix master, to avoid confusion for contributors, especially since it seems to apply to the ending python 2 |
anuragkapale
pushed a commit
to anuragkapale/scikit-learn
that referenced
this pull request
Oct 23, 2018
jnothman
pushed a commit
to jnothman/scikit-learn
that referenced
this pull request
Nov 14, 2018
Merged
xhluca
pushed a commit
to xhluca/scikit-learn
that referenced
this pull request
Apr 28, 2019
xhluca
pushed a commit
to xhluca/scikit-learn
that referenced
this pull request
Apr 28, 2019
…earn#12382)" This reverts commit 4b47ef5.
xhluca
pushed a commit
to xhluca/scikit-learn
that referenced
this pull request
Apr 28, 2019
…earn#12382)" This reverts commit 4b47ef5.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Apologies an accident in Appveyor prevent me from seeing this error (python2.7 32bit Appveyor).
I'm unable to come up with a good solution, maybe remove the test is acceptable since we already have one for normal csr matrix, or we can skip it on 32bit machine, but I'm not sure when it will happen.
ping @jnothman