TST: update make_column_transformer test + add comment#12156
Merged
qinhanmin2014 merged 1 commit intoscikit-learn:masterfrom Sep 25, 2018
Merged
TST: update make_column_transformer test + add comment#12156qinhanmin2014 merged 1 commit intoscikit-learn:masterfrom
qinhanmin2014 merged 1 commit intoscikit-learn:masterfrom
Conversation
Follow-up on scikit-learn#12152 And added comment why transformer_weights is not passed through, see scikit-learn#11183 (review) for more discussion
qinhanmin2014
approved these changes
Sep 25, 2018
Member
qinhanmin2014
left a comment
There was a problem hiding this comment.
LGTM. Let's merge when green.
jnothman
pushed a commit
to jnothman/scikit-learn
that referenced
this pull request
Oct 15, 2018
…2156) Follow-up on scikit-learn#12152 And added comment why transformer_weights is not passed through, see scikit-learn#11183 (review) for more discussion
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up on #12152
And added comment why transformer_weights is not passed through, see
#11183 (review)
for more discussion