[MRG] Fix description of SVC intercept_ shape in user guide.#12070
[MRG] Fix description of SVC intercept_ shape in user guide.#12070rth merged 1 commit intoscikit-learn:masterfrom
Conversation
rth
left a comment
There was a problem hiding this comment.
LGTM, thanks!
It would also be good to emphasize in the docsting for SVC.coef_ that the shape is not necessarily [n_class-1, n_features].
Now it uses several levels of indirection:
coef_ -> read only of dual_coef_ -> The layout of the coefficients in the multiclass case is somewhat non-trivial, see docs.
|
I suspect I'm missing something with respect to @rth's comment... Did you amend a commit @zdgriffith ? If so, please avoid it. |
|
No, in the initial Github comment where I said "..in the docstring" I linked to v0.19.2 of the docs. @rth's suggestion regarding |
rth
left a comment
There was a problem hiding this comment.
I must indeed have checked the outdated docs..
Thanks for this PR!
The shape of the
intercept_attribute ofsklearn.svm.SVCis correctly [n_class * (n_class-1) / 2] in the docstring but in the user guide it is implied the shape is [n_class]. This PR fixes the description in the user guide.