Skip to content

[MRG] TST use urlopen monkeypatch for test_decode_*#12020

Merged
rth merged 2 commits intoscikit-learn:masterfrom
jnothman:monkey
Sep 6, 2018
Merged

[MRG] TST use urlopen monkeypatch for test_decode_*#12020
rth merged 2 commits intoscikit-learn:masterfrom
jnothman:monkey

Conversation

@jnothman
Copy link
Copy Markdown
Member

@jnothman jnothman commented Sep 6, 2018

Avoid requiring internet for test suite. Examples will still run with internet (as long as cache is occasionally cleared).

Fixes #11972

Copy link
Copy Markdown
Member

@rth rth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@rth rth merged commit 1fafc5c into scikit-learn:master Sep 6, 2018
jnothman added a commit to jnothman/scikit-learn that referenced this pull request Sep 6, 2018
Avoid requiring internet for test suite. Examples will still run with internet (as long as cache is occasionally cleared).
jnothman added a commit to jnothman/scikit-learn that referenced this pull request Sep 17, 2018
Avoid requiring internet for test suite. Examples will still run with internet (as long as cache is occasionally cleared).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants