MAINT make pytest collection ignore folders with Python scripts#12011
Merged
ogrisel merged 1 commit intoscikit-learn:masterfrom Sep 5, 2018
Merged
MAINT make pytest collection ignore folders with Python scripts#12011ogrisel merged 1 commit intoscikit-learn:masterfrom
ogrisel merged 1 commit intoscikit-learn:masterfrom
Conversation
Some IDEs such as VS Code use the pytest command to collect all the tests of the workspace in the background. This can cause unexpected execution of arbitrary Python scripts in the workspace (examples, benchmarks...). The doc folder is also ignored because it has python scripts for sphinx along with copies of the examples. To safely run pytest in the doc folder, we need to used the find command to find all "*.rst" files as done in the project Makefile.
jnothman
pushed a commit
to jnothman/scikit-learn
that referenced
this pull request
Sep 6, 2018
…it-learn#12011) Some IDEs such as VS Code use the pytest command to collect all the tests of the workspace in the background. This can cause unexpected execution of arbitrary Python scripts in the workspace (examples, benchmarks...). The doc folder is also ignored because it has python scripts for sphinx along with copies of the examples. To safely run pytest in the doc folder, we need to used the find command to find all "*.rst" files as done in the project Makefile.
jnothman
pushed a commit
to jnothman/scikit-learn
that referenced
this pull request
Sep 17, 2018
…it-learn#12011) Some IDEs such as VS Code use the pytest command to collect all the tests of the workspace in the background. This can cause unexpected execution of arbitrary Python scripts in the workspace (examples, benchmarks...). The doc folder is also ignored because it has python scripts for sphinx along with copies of the examples. To safely run pytest in the doc folder, we need to used the find command to find all "*.rst" files as done in the project Makefile.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some IDEs such as VS Code use the pytest command to collect all the tests of
the workspace in the background. This can cause unexpected execution of
arbitrary Python scripts in the workspace (examples, benchmarks...).
The doc folder is also ignored because it has python scripts for sphinx
along with copies of the examples.
To safely run pytest in the doc folder, we need to use the find command
to find all "*.rst" files as done in the project Makefile.