MNT Revert the deprecation of min_samples_leaf and min_weight_fraction_leaf#11998
Merged
rth merged 2 commits intoscikit-learn:masterfrom Sep 8, 2018
Merged
MNT Revert the deprecation of min_samples_leaf and min_weight_fraction_leaf#11998rth merged 2 commits intoscikit-learn:masterfrom
rth merged 2 commits intoscikit-learn:masterfrom
Conversation
amueller
approved these changes
Sep 7, 2018
Member
amueller
left a comment
There was a problem hiding this comment.
I agree. Sorry for pushing for this, clearly not thinking about all cases.
Member
|
can we tag blockers for the final release? |
jnothman
added a commit
to jnothman/scikit-learn
that referenced
this pull request
Sep 9, 2018
jnothman
added a commit
to jnothman/scikit-learn
that referenced
this pull request
Sep 17, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
And improve the documentation of
min_samples_leaf.Fixes #11976
What do others think?