[MRG] DOC replace 'interesting' with 'better' for model_persistence#11946
Merged
qinhanmin2014 merged 1 commit intoscikit-learn:masterfrom Aug 30, 2018
Merged
[MRG] DOC replace 'interesting' with 'better' for model_persistence#11946qinhanmin2014 merged 1 commit intoscikit-learn:masterfrom
qinhanmin2014 merged 1 commit intoscikit-learn:masterfrom
Conversation
'interesting' isn't directly supported by the following claim (i.e., that joblib can be more efficient than pickle), and also describing this as interesting isn't very useful to the user in my opinion.
Member
|
Yes, it's not idiomatic English... Maybe someone meant "more of interest" |
jnothman
approved these changes
Aug 30, 2018
Member
|
Thanks |
jnothman
pushed a commit
to jnothman/scikit-learn
that referenced
this pull request
Sep 2, 2018
…-learn#11946) 'interesting' isn't directly supported by the following claim (i.e., that joblib can be more efficient than pickle), and also describing this as interesting isn't very useful to the user in my opinion.
jnothman
pushed a commit
to jnothman/scikit-learn
that referenced
this pull request
Sep 17, 2018
…-learn#11946) 'interesting' isn't directly supported by the following claim (i.e., that joblib can be more efficient than pickle), and also describing this as interesting isn't very useful to the user in my opinion.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
What does this implement/fix? Explain your changes.
The following language can be found here:
But "more interesting" isn't directly supported by the following claim (i.e., that joblib can be more efficient than pickle), and also describing this as interesting isn't very useful to the user in my opinion. I think "better" or "more efficient" is more suitable here.
Any other comments?