Skip to content

DOCS: noting y is present in one-class fit methods merely for API consistency#11939

Merged
jnothman merged 5 commits intoscikit-learn:masterfrom
raamana:y-ignored-one-class-methods
Aug 30, 2018
Merged

DOCS: noting y is present in one-class fit methods merely for API consistency#11939
jnothman merged 5 commits intoscikit-learn:masterfrom
raamana:y-ignored-one-class-methods

Conversation

@raamana
Copy link
Copy Markdown
Contributor

@raamana raamana commented Aug 29, 2018

This is a continuation of and closes #11933

Copy link
Copy Markdown
Contributor

@albertcthomas albertcthomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @raamana! Could you do the same for fit_predict in OutlierMixin here?

@raamana
Copy link
Copy Markdown
Contributor Author

raamana commented Aug 29, 2018

NP. Good pointer, fixed it for OutlierMixin. I also took the liberty to make the same changes in few other places. As Joel pointed out in #11933 , this problem exists in many other places, where clustering is involved. While Ignored is better than None, but mentioning the reason why developers chose this (everywhere its used) would be the way to go.

Copy link
Copy Markdown
Member

@jnothman jnothman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've not checked this is complete, but it's a helpful change. Thanks!

@jnothman jnothman merged commit 1a61f50 into scikit-learn:master Aug 30, 2018
@raamana
Copy link
Copy Markdown
Contributor Author

raamana commented Aug 30, 2018

Yay! My first contribution into the mighty scikit-learn ;).. You’re welcome - looking fwd to contribute even more!

jnothman pushed a commit to jnothman/scikit-learn that referenced this pull request Aug 30, 2018
jnothman pushed a commit to jnothman/scikit-learn that referenced this pull request Sep 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants