MNT log1p -> log in cython files#11852
Merged
qinhanmin2014 merged 1 commit intoscikit-learn:masterfrom Aug 18, 2018
qinhanmin2014:appveyor-failure
Merged
MNT log1p -> log in cython files#11852qinhanmin2014 merged 1 commit intoscikit-learn:masterfrom qinhanmin2014:appveyor-failure
qinhanmin2014 merged 1 commit intoscikit-learn:masterfrom
qinhanmin2014:appveyor-failure
Conversation
Member
|
With respect to the error mentioned in #11848, I think the issue is that MSVC didn't include log1p in older versions (cf e.g. rust-lang/rust#29479). This is something we can revert once python 2 support is dropped (as Python 3 uses a newer version of MSVC on windows). |
Contributor
|
FWIW NumPy handles the problem by defining |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Revert the cython part of #11428
Will merge when green.