Replacing log with log1p where applicable.#11428
Merged
qinhanmin2014 merged 7 commits intoscikit-learn:masterfrom Jul 14, 2018
Merged
Replacing log with log1p where applicable.#11428qinhanmin2014 merged 7 commits intoscikit-learn:masterfrom
qinhanmin2014 merged 7 commits intoscikit-learn:masterfrom
Conversation
jnothman
approved these changes
Jul 4, 2018
Member
|
It seems that the PR is not complete, please carefully follow #11424 (comment). |
jnothman
reviewed
Jul 5, 2018
Member
jnothman
left a comment
There was a problem hiding this comment.
You're right... I was lax to not check, while on my phone.
qinhanmin2014
approved these changes
Jul 14, 2018
Member
qinhanmin2014
left a comment
There was a problem hiding this comment.
LGTM. Will merge when green.
Member
|
This is not the right fix and is likely to lead to performance issues, I think. You shouldn't use the numpy function in cython code, you should be using |
This was referenced Aug 17, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
What does this implement/fix? Explain your changes.
Any other comments?