[MRG+1] FIX hotfix for joblib#741#11837
Conversation
|
|
|
Travis CI fails due |
|
Restarted Circle CI, hopefully it should pass now that #11466 is merged. Apart for it making CI pass, I don't have a good understanding of the side effects this change may have. It would have been great to have an option from joblib core devs on this, even if it's a temporary hotfix (cc @lesteve @GaelVaroquaux ) .. For future reference, PRs aiming to fix this properly are joblib/joblib#743 and joblib/joblib#746 |
|
The aim here would be to be able to declare an RC (we can't do that without live docs), but not release a final version without overwriting this with the official fix. |
qinhanmin2014
left a comment
There was a problem hiding this comment.
I'm +1 to merge this one and release the RC. It seems reasonable and Circle is green.
rth
left a comment
There was a problem hiding this comment.
LGTM as far as the tests and CI goes. Merging.
|
I'm also impatient, I mostly want to resolve the logistic regression thing so we can have the multinomial solver. |
I'm getting impatient for the 0.20 release, admittedly.
This is so we can get the dev docs compiling online, so that we can announce an RC that includes joblib 0.12/loky (not that we get much feedback from an RC).
Is a hotfix acceptable here, assuming that Joblib will be fixed before final release?